Simple clang-tidy fixes #1589
Merged
Simple clang-tidy fixes #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Febbe
force-pushed
the
apply_clang_tidy
branch
from
115fe76
to
91d97c1
Compare
Febbe
force-pushed
the
apply_clang_tidy
branch
4 times, most recently
from
4eeac67
to
dac7f9f
Compare
Febbe
force-pushed
the
apply_clang_tidy
branch
from
8a577f8
to
a2e98f4
Compare
|
I would like to merge those changes the next few days. |
|
One quick question: Shouldn't the Clang Format check sign green with this? 😉 |
Yes, but we want to swap the clang-format to the 4 indent google stile anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only modernize-* changes, that could be done without errors.
This should be mergeable directly.