-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compass #4443
Add compass #4443
Conversation
d300be5
to
cda7287
Compare
After #4211 has been reviewed and merged, this PR may be ready for review. |
268bead
to
18376c2
Compare
73e2f3c
to
1f02dff
Compare
Rebased on master after merging the setsquare refactoring. This is ready for review. |
4a1a176
to
bfe1bd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed through the code quickly, some comments below.
bfe1bd9
to
d90ffe6
Compare
a15d10b
to
b5a90c9
Compare
7cf5ff9
to
133c170
Compare
Merging in 48 hours if no objections are raised. |
I played around with this briefly and noticed a few things:
These are not major showstoppers, so they can be addressed in a follow up. |
Thanks for the feedback.
I'm working on it.
It's the same for drawing on the outline of the compass and for drawing on the longest side of the setsquare or drawing on physical paper.
Interesting idea. It wouldn't allow drawing circular ring (sectors) anymore though.
Is that also a bug of moving the page around (without geometry tools then)? Haven't thought about having multiple arrow keys at the same time.
|
This PR is split off from (and based on) #4211. Only the
last commit 96354a9 is relevantcommits from "Add compass" are relevant.Here is a little demo (mostly using the keyboard;
m
is for marking the center):CompassDemo.mp4
Edit: Added demo (Nov 27)