-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add geometry tools documentation #77
Conversation
docs/guide/tools/geometry.md
Outdated
![Setsquare-Overview](../../img/guide/setsquare_overview.png) | ||
|
||
The longest side of the setsquare is used for measuring lengths and to draw lines aligned to it. | ||
Units are centimeters for lengths and degrees for angles. There are marks (in green) parallel |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
docs/guide/tools/geometry.md
Outdated
|
||
### Interaction with other tools | ||
|
||
**Stylus/Mouse** interact with the Pen, Highlighter and Hand tool |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
532cc2c
to
a34f973
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, I have a few suggestions below.
docs/guide/tools/geometry.md
Outdated
Using the keyboard (`m` key) the current distinguished point can be marked with an "x"-like shape | ||
that is added to the page. For example when drawing a circle the center using the compass, | ||
the center of the circle can be marked like that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be moved to the keyboard controls section. They seem out of place here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is already written in the keyboard controls section, I have just removed it here.
In order to setup the geometry tools, check your Display DPI Calibration in the Zoom panel of menu | ||
`Edit > Preferences` to ensure that the length on your screen matches the physical length. Set | ||
the zoom to 100% to profit from the calibration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should set the zoom to 100% before calibration. Might also want to suggest using a physical ruler to compare the length.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the review @Technius I will squash the last 3 commits into one and merge in 48 hours if no objections are raised. |
Co-authored-by: Bryan Tan <Technius@users.noreply.github.com>
This is taken from the development documentation. It's the first part of it. The plan is to replace the first part of the development documentation on the setsquare by a link to the website and to just keep the second part, which contains the implementation details.