Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issue with busybox stty #1

Closed
dhuffer opened this issue Feb 17, 2014 · 3 comments · Fixed by #2
Closed

Compatibility issue with busybox stty #1

dhuffer opened this issue Feb 17, 2014 · 3 comments · Fixed by #2

Comments

@dhuffer
Copy link

dhuffer commented Feb 17, 2014

While it is possible to use the busybox applet stty, the check is failing because the busybox version of stty does not support the "--version" parameter.
Removing the parameter from the check inside the function phpSerial fixes this issue.

@Xowap
Copy link
Owner

Xowap commented Feb 18, 2014

Awesome dhuffer, thank you for this first issue \o/

I fixed it in PR #2, can you check it out and tell me if it works as expected?

It seems to be good with the regular stty as well.

@dhuffer
Copy link
Author

dhuffer commented Feb 18, 2014

It's working perfectly with my busybox installation.
Did'nt check with a stock stty.

Thanks for the quick response :-)

On 02/18/2014 01:58 AM, Rémy Sanchez wrote:

Awesome dhuffer, thank you for this first issue \o/

I fixed it in PR #2 #2, can
you check it out and tell me if it works as expected?

It seems to be good with the regular stty as well.


Reply to this email directly or view it on GitHub
#1 (comment).

@Xowap Xowap closed this as completed in #2 Feb 21, 2014
@Xowap
Copy link
Owner

Xowap commented Feb 21, 2014

@dhuffer you're welcome, it's now merged in the develop branch and I re-released the package :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants