Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: make writer work #139

Merged
merged 15 commits into from
May 27, 2018
Merged

WIP: make writer work #139

merged 15 commits into from
May 27, 2018

Conversation

CJ-Wright
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented May 25, 2018

Codecov Report

Merging #139 into master will decrease coverage by 0.31%.
The diff coverage is 88.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
- Coverage   95.84%   95.52%   -0.32%     
==========================================
  Files          19       21       +2     
  Lines        2404     2504     +100     
  Branches      561      576      +15     
==========================================
+ Hits         2304     2392      +88     
- Misses         49       57       +8     
- Partials       51       55       +4
Impacted Files Coverage Δ
shed/tests/test_writers.py 100% <100%> (ø)
shed/tests/test_translation.py 100% <100%> (ø) ⬆️
shed/translation.py 90.78% <100%> (+0.93%) ⬆️
shed/writers.py 78.18% <78.18%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e8a0ce...3710399. Read the comment docs.

@CJ-Wright
Copy link
Member Author

This needs more tests.

@CJ-Wright
Copy link
Member Author

The lack of coverage is due to parts of the writer not covered. I'm willing to accept that.

@CJ-Wright CJ-Wright merged commit 8263dd7 into xpdAcq:master May 27, 2018
@CJ-Wright CJ-Wright deleted the writer branch May 27, 2018 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants