-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to start shadow session #4129
Comments
The commit above should fix this particular issue, but there are some other issues I am working through. |
Thanks for the update, I can certainly remain patient if this aspect is a work in progress. I usually struggle with when to report something or not 😛 I'm now seeing this in
|
That's one of them! diff --git a/xpra/server/rfb/server.py b/xpra/server/rfb/server.py
index c324a5feae..1dc47c9f0c 100644
--- a/xpra/server/rfb/server.py
+++ b/xpra/server/rfb/server.py
@@ -3,6 +3,7 @@
# Xpra is released under the terms of the GNU GPL v2, or, at your option, any
# later version. See the file COPYING for details.
# pylint: disable-msg=E1101
+import os
from xpra.util.str_fn import repr_ellipsized, bytestostr
from xpra.util.system import is_X11
@@ -31,11 +32,11 @@ class RFBServer:
self.rfb_buttons = 0
self.x11_keycodes_for_keysym = {}
self.X11Keyboard = None
- if is_X11():
+ if os.environ.get("DISPLAY") and is_X11():
try:
from xpra.x11.bindings.keyboard import X11KeyboardBindings
self.X11Keyboard = X11KeyboardBindings()
- except ImportError:
+ except (ImportError, RuntimeError):
log("RFBServer", exc_info=True)
log.warn("Warning: no x11 bindings")
log.warn(" some RFB keyboard events may be missing") |
I applied this patch and now the shadow session starts up, doing If it matters:
|
when using portal / remotedesktop shadow modes
@sbradnick 3d16560 is a better fix. |
Thanks for the heads up :) I built it and installed it on 2 machines: [server]: laptop w/ 9th Gen Intel and NVIDIA T1000 (but dGPU isn't being used, display uses Intel iGPU) Both machines have their NVIDIA GPUs dedicated to vfio for gpu-passthrough for KVM/libvirtd ~ so hopefully they're not a part of this picture, I don't expect them to come into play for using xpra.
server error:
client error:
I also tried each option in the list here:
And while I didn't get red errors printed for openh264, vpx, nvdec; a connection wasn't successful and they all seem to throw that same server error. Seems "gstreamer" might be the default. |
This is a server-side error.
How many displays are running on this system? Are they wayland or X11? What DE? |
Just 1 display for both; client has 1 1440p monitor connected via displayport, server has laptop screen at 1080p. Both are X11; client is using i3 and server is using icewm. I do have
|
@sbradnick is this still an issue? |
As of e2d97e3, this is also working again :) - awesome stuff! |
Describe the bug
As far as I can tell, starting a shadow session is just erroring out.
If I use a build up to fc4b6d1 , it works fine - but I rebuilt to f845c2d and am seeing this issue. Just tried up to a03569a and having the same issue. I took a look @ the blame for scripts/main.py#136 and something did change recently, but I won't pretend I can debug it ;)
To Reproduce
Steps to reproduce the behavior:
xpra shadow --bind-tcp=<local_ip_of_remote_host>:10000
; also tried to start via runningxpra
while logged into:0
.xpra attach tcp://<local_ip_of_remote_host>:10000
)specific action to trigger the bugSystem Information (please complete the following information):
Additional context
From
/run/user/1000/xpra/0/server.log
:The text was updated successfully, but these errors were encountered: