Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move aes_string() to aes() #116

Closed
MichaelChirico opened this issue Jun 10, 2023 · 1 comment
Closed

Move aes_string() to aes() #116

MichaelChirico opened this issue Jun 10, 2023 · 1 comment
Labels
duplicate Issue is already covered by an other one.

Comments

@MichaelChirico
Copy link
Contributor

pROC/R/ggroc.R

Line 34 in edcd42d

aes <- do.call(ggplot2::aes_string, aes_list)

aes_string() is deprecated and it throws a warning in the testthat suite (at test-ggroc.R:9:2).

https://ggplot2.tidyverse.org/reference/aes_.html
@xrobin xrobin added the duplicate Issue is already covered by an other one. label Jun 11, 2023
@xrobin
Copy link
Owner

xrobin commented Jun 11, 2023

This was already reported in #113.

@xrobin xrobin closed this as completed Jun 11, 2023
@xrobin xrobin closed this as not planned Won't fix, can't repro, duplicate, stale Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate Issue is already covered by an other one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xrobin @MichaelChirico