-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coords is too slow with many thresholds #52
Comments
The function is mostly vectorized now, except the part that matches the user-supplied thresholds to ours. One difficulty is that we can't rely on the threshold values themselves and must look at the predictors instead. This step still relies on a call to |
The thresholds are now determined with a for and while loop in something like O(n). Ugly but very efficient.
Keeping the issue open to ponder whether it is worth updating the function with input="se" and input="sp". Those still call match repeatedly, however it is unclear whether that will be a problem as we never go along all of them systematically like with x="all". |
Skipping the step through numeric thresholds, and skipping the calculation of extra coordinates when only the existing se/sp/thr are requested, saves even more time.
|
I would expect it to complete more or less instantly.
The text was updated successfully, but these errors were encountered: