Provide public methods to adjust log levels from C++ code

[bbockelm]

It turns out that CMSSW defines "likely" and "unlikely" symbols in its own source code - XrdClOptimizers.hh redefines these, resulting in an error.

Can you put them inside the XrdCl namespace?

[ljanyst]

Hi Brian,

I don't understand why you see a problem with this... it's a marcro so it does not result with a symbol in the library and it's not accessible from any of the public headers...

Cheers,
Lukasz

[bbockelm]

Could be I'm using things wrong. (Well, definitely doing something wrong if I'm using a non-public header!)

I want to increase the debug level of the default logger. I was trying to do something like:

XrdCl::Log *logger = XrdCl::DefaultEnv::GetLog();
logger.SetLevel(XrdCl::Log::LogLevel::ErrorMsg);

To get the definition of XrdCl::Log, it appears I wandered to a non-public header and hit this issue.

What's the best way to do this?

[ljanyst]

Currently there is no way to do this from inside of a program without using private headers. I will put the necessary methods in the DefaultEnv class.

[bbockelm]

Ah, ok.

OK if I close this ticket and open a new one specific to adjusting log levels?

[ljanyst]

I think we can keep it in this one - I will change the title.

[ljanyst]

Done: ab7d700