Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XrdCl] Fix some typos #9

Merged
merged 1 commit into from
Apr 26, 2013
Merged

[XrdCl] Fix some typos #9

merged 1 commit into from
Apr 26, 2013

Conversation

jlsalmon
Copy link
Contributor

No description provided.

@ljanyst
Copy link
Contributor

ljanyst commented Apr 26, 2013

Oh wow, apparently I don't know how to properly spell "successful" :) Thanks! :)

@ljanyst ljanyst merged commit 20fae12 into xrootd:master Apr 26, 2013
@esindril esindril mentioned this pull request Nov 4, 2013
Closed
@abh3 abh3 mentioned this pull request Nov 30, 2013
Closed
@smithdh smithdh mentioned this pull request Apr 10, 2014
Closed
@tommasoboccali tommasoboccali mentioned this pull request Nov 5, 2014
Closed
@sponce sponce mentioned this pull request Feb 3, 2015
Closed
@apeters1971 apeters1971 mentioned this pull request Feb 25, 2015
Closed
@apeters1971 apeters1971 mentioned this pull request Jul 6, 2015
Closed
@esindril esindril mentioned this pull request Jul 7, 2015
Merged
@simonmichal simonmichal mentioned this pull request Sep 21, 2015
Closed
@esindril esindril mentioned this pull request Sep 22, 2015
Closed
@abh3 abh3 mentioned this pull request Sep 23, 2015
Closed
@jknedlik jknedlik mentioned this pull request Feb 23, 2016
Closed
@simonmichal simonmichal mentioned this pull request Apr 22, 2016
Closed
@jmuf jmuf mentioned this pull request Jul 14, 2016
Closed
@esindril esindril mentioned this pull request Sep 21, 2016
Closed
@abh3 abh3 mentioned this pull request Oct 13, 2016
Closed
@bastianbeischer bastianbeischer mentioned this pull request Nov 7, 2016
Closed
@bastianbeischer bastianbeischer mentioned this pull request Feb 7, 2017
Closed
@simonmichal simonmichal mentioned this pull request Feb 14, 2017
Closed
@apeters1971 apeters1971 mentioned this pull request Jun 26, 2017
Closed
@apeters1971 apeters1971 mentioned this pull request Oct 24, 2017
Closed
gbitzes added a commit to gbitzes/xrootd that referenced this pull request Nov 15, 2017
@gbitzes
[XrdSys] Fix data race on cP->dlType
0481107 
cP->dlType is being read outside of the lock. Diagnosed through the
following report from ThreadSanitizer:

WARNING: ThreadSanitizer: data race (pid=13166)
  Write of size 1 at 0x7b28000100d0 by thread T29 (mutexes: write M0, write M0, write M1382, write M0, write M1385):
    #0 XrdSys::IOEvents::Poller::TmoAdd(XrdSys::IOEvents::Channel*, int) /home/gbitzes/xrootd/src/XrdSys/XrdSysIOEvents.cc:1088 (libXrdUtils.so.2+0x0000000338f1)
    xrootd#1 XrdSys::IOEvents::Channel::Enable(int, int, char const**) /home/gbitzes/xrootd/src/XrdSys/XrdSysIOEvents.cc:415 (libXrdUtils.so.2+0x0000000355b6)
    xrootd#2 XrdCl::PollerBuiltIn::EnableWriteNotification(XrdCl::Socket*, bool, unsigned short) /home/gbitzes/xrootd/src/XrdCl/XrdClPollerBuiltIn.cc:481 (libXrdCl.so.2+0x000000063c50)
    xrootd#3 XrdCl::AsyncSocketHandler::EnableUplink() /home/gbitzes/xrootd/src/./XrdCl/XrdClAsyncSocketHandler.hh:96 (libXrdCl.so.2+0x00000006d06f)
    xrootd#4 XrdCl::Stream::EnableLink(XrdCl::PathID&) /home/gbitzes/xrootd/src/XrdCl/XrdClStream.cc:226 (libXrdCl.so.2+0x00000006d06f)
    xrootd#5 XrdCl::Stream::Send(XrdCl::Message*, XrdCl::OutgoingMsgHandler*, bool, long) /home/gbitzes/xrootd/src/XrdCl/XrdClStream.cc:316 (libXrdCl.so.2+0x00000006e0d7)
    xrootd#6 XrdCl::Channel::Send(XrdCl::Message*, XrdCl::OutgoingMsgHandler*, bool, long, XrdCl::VirtualRedirector*) /home/gbitzes/xrootd/src/XrdCl/XrdClChannel.cc:306 (libXrdCl.so.2+0x000000068686)
    xrootd#7 XrdCl::PostMaster::Send(XrdCl::URL const&, XrdCl::Message*, XrdCl::OutgoingMsgHandler*, bool, long) /home/gbitzes/xrootd/src/XrdCl/XrdClPostMaster.cc:198 (libXrdCl.so.2+0x000000066ec9)
    xrootd#8 XrdCl::MessageUtils::SendMessage(XrdCl::URL const&, XrdCl::Message*, XrdCl::ResponseHandler*, XrdCl::MessageSendParams const&) /home/gbitzes/xrootd/src/XrdCl/XrdClMessageUtils.cc:114 (libXrdCl.so.2+0x0000000b349e)
    xrootd#9 XrdCl::FileSystem::Send(XrdCl::Message*, XrdCl::ResponseHandler*, XrdCl::MessageSendParams&) /home/gbitzes/xrootd/src/XrdCl/XrdClFileSystem.cc:1419 (libXrdCl.so.2+0x000000085b3d)
    xrootd#10 XrdCl::FileSystem::Query(XrdCl::QueryCode::Code, XrdCl::Buffer const&, XrdCl::ResponseHandler*, unsigned short) /home/gbitzes/xrootd/src/XrdCl/XrdClFileSystem.cc:720 (libXrdCl.so.2+0x00000008fbe3)
    xrootd#11 XrdCl::FileSystem::Query(XrdCl::QueryCode::Code, XrdCl::Buffer const&, XrdCl::Buffer*&, unsigned short) /home/gbitzes/xrootd/src/XrdCl/XrdClFileSystem.cc:732 (libXrdCl.so.2+0x00000009006e)
    xrootd#12 backend::Query(XrdCl::FileSystem&, XrdCl::QueryCode::Code, XrdCl::Buffer&, XrdCl::Buffer*&) /afs/cern.ch/user/g/gbitzes/dev/eos/fusex/backend/backend.cc:875 (eosxd+0x00000067fb9f)
    xrootd#13 backend::putMD(fuse_id const&, eos::fusex::md*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, XrdSysMutex*) /afs/cern.ch/user/g/gbitzes/dev/eos/fusex/backend/backend.cc:454 (eosxd+0x00000068912e)
    xrootd#14 metad::mdcflush(ThreadAssistant&) /afs/cern.ch/user/g/gbitzes/dev/eos/fusex/md/md.cc:1887 (eosxd+0x000000611515)
    xrootd#15 void std::__invoke_impl<void, void (metad::*)(ThreadAssistant&), metad*, ThreadAssistant&>(std::__invoke_memfun_deref, void (metad::*&&)(ThreadAssistant&), metad*&&, ThreadAssistant&) /usr/include/c++/7/bits/invoke.h:73 (eosxd+0x0000005b1fb6)
    xrootd#16 std::__invoke_result<void (metad::*)(ThreadAssistant&), metad*, ThreadAssistant&>::type std::__invoke<void (metad::*)(ThreadAssistant&), metad*, ThreadAssistant&>(void (metad::*&&)(ThreadAssistant&), metad*&&, ThreadAssistant&) /usr/include/c++/7/bits/invoke.h:95 (eosxd+0x0000005b1fb6)
    xrootd#17 decltype (__invoke((_S_declval<0ul>)(), (_S_declval<1ul>)(), (_S_declval<2ul>)())) std::thread::_Invoker<std::tuple<void (metad::*)(ThreadAssistant&), metad*, ThreadAssistant&> >::_M_invoke<0ul, 1ul, 2ul>(std::_Index_tuple<0ul, 1ul, 2ul>) /usr/include/c++/7/thread:234 (eosxd+0x0000005b1fb6)
    xrootd#18 std::thread::_Invoker<std::tuple<void (metad::*)(ThreadAssistant&), metad*, ThreadAssistant&> >::operator()() /usr/include/c++/7/thread:243 (eosxd+0x0000005b1fb6)
    xrootd#19 std::thread::_State_impl<std::thread::_Invoker<std::tuple<void (metad::*)(ThreadAssistant&), metad*, ThreadAssistant&> > >::_M_run() /usr/include/c++/7/thread:186 (eosxd+0x0000005b1fb6)
    xrootd#20 <null> <null> (libstdc++.so.6+0x0000000bc01e)

  Previous read of size 1 at 0x7b28000100d0 by thread T34:
    #0 XrdSys::IOEvents::Poller::CbkTMO() /home/gbitzes/xrootd/src/XrdSys/XrdSysIOEvents.cc:597 (libXrdUtils.so.2+0x000000034d8a)
    xrootd#1 XrdSys::IOEvents::Poller::TmoGet() /home/gbitzes/xrootd/src/XrdSys/XrdSysIOEvents.cc:1150 (libXrdUtils.so.2+0x000000035166)
    xrootd#2 XrdSys::IOEvents::PollE::Begin(XrdSysSemaphore*, int&, char const**) /home/gbitzes/xrootd/src/./XrdSys/XrdSysIOEventsPollE.icc:213 (libXrdUtils.so.2+0x000000036787)
    xrootd#3 XrdSys::IOEvents::BootStrap::Start(void*) /home/gbitzes/xrootd/src/XrdSys/XrdSysIOEvents.cc:131 (libXrdUtils.so.2+0x000000030c5c)
    xrootd#4 XrdSysThread_Xeq /home/gbitzes/xrootd/src/XrdSys/XrdSysPthread.cc:86 (libXrdUtils.so.2+0x00000002d50f)
    xrootd#5 <null> <null> (libtsan.so.0+0x0000000257eb)

  Location is heap block of size 152 at 0x7b2800010040 allocated by thread T33:
    #0 operator new(unsigned long) <null> (libtsan.so.0+0x00000006f766)
    xrootd#1 XrdCl::PollerBuiltIn::AddSocket(XrdCl::Socket*, XrdCl::SocketHandler*) /home/gbitzes/xrootd/src/XrdCl/XrdClPollerBuiltIn.cc:295 (libXrdCl.so.2+0x000000064801)
    xrootd#2 XrdCl::AsyncSocketHandler::Connect(long) /home/gbitzes/xrootd/src/XrdCl/XrdClAsyncSocketHandler.cc:167 (libXrdCl.so.2+0x000000114155)
    xrootd#3 XrdCl::Stream::EnableLink(XrdCl::PathID&) /home/gbitzes/xrootd/src/XrdCl/XrdClStream.cc:271 (libXrdCl.so.2+0x00000006db5c)
    xrootd#4 XrdCl::Stream::Send(XrdCl::Message*, XrdCl::OutgoingMsgHandler*, bool, long) /home/gbitzes/xrootd/src/XrdCl/XrdClStream.cc:316 (libXrdCl.so.2+0x00000006e0d7)
    xrootd#5 XrdCl::Channel::Send(XrdCl::Message*, XrdCl::OutgoingMsgHandler*, bool, long, XrdCl::VirtualRedirector*) /home/gbitzes/xrootd/src/XrdCl/XrdClChannel.cc:306 (libXrdCl.so.2+0x000000068686)
    xrootd#6 XrdCl::PostMaster::Send(XrdCl::URL const&, XrdCl::Message*, XrdCl::OutgoingMsgHandler*, bool, long) /home/gbitzes/xrootd/src/XrdCl/XrdClPostMaster.cc:198 (libXrdCl.so.2+0x000000066ec9)
    xrootd#7 XrdCl::MessageUtils::SendMessage(XrdCl::URL const&, XrdCl::Message*, XrdCl::ResponseHandler*, XrdCl::MessageSendParams const&) /home/gbitzes/xrootd/src/XrdCl/XrdClMessageUtils.cc:114 (libXrdCl.so.2+0x0000000b349e)
    xrootd#8 XrdCl::FileStateHandler::Open(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned short, unsigned short, XrdCl::ResponseHandler*, unsigned short) /home/gbitzes/xrootd/src/XrdCl/XrdClFileStateHandler.cc:525 (libXrdCl.so.2+0x0000000c6d3c)
    xrootd#9 XrdCl::File::Open(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, XrdCl::OpenFlags::Flags, XrdCl::Access::Mode, XrdCl::ResponseHandler*, unsigned short) /home/gbitzes/xrootd/src/XrdCl/XrdClFile.cc:108 (libXrdCl.so.2+0x0000000b9929)
    xrootd#10 XrdCl::File::Open(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, XrdCl::OpenFlags::Flags, XrdCl::Access::Mode, unsigned short) /home/gbitzes/xrootd/src/XrdCl/XrdClFile.cc:120 (libXrdCl.so.2+0x0000000b9a8b)
    xrootd#11 backend::fetchResponse(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, std::vector<eos::fusex::container, std::allocator<eos::fusex::container> >&) /afs/cern.ch/user/g/gbitzes/dev/eos/fusex/backend/backend.cc:220 (eosxd+0x0000006860e5)
    xrootd#12 backend::getMD(fuse_req*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::vector<eos::fusex::container, std::allocator<eos::fusex::container> >&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) /afs/cern.ch/user/g/gbitzes/dev/eos/fusex/backend/backend.cc:152 (eosxd+0x000000687dd2)
    xrootd#13 metad::get(fuse_req*, unsigned long, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, bool, std::shared_ptr<metad::mdx>, char const*, bool) /afs/cern.ch/user/g/gbitzes/dev/eos/fusex/md/md.cc:576 (eosxd+0x00000061b6a5)
    xrootd#14 metad::lookup(fuse_req*, unsigned long, char const*) /afs/cern.ch/user/g/gbitzes/dev/eos/fusex/md/md.cc:176 (eosxd+0x00000061cd61)
    xrootd#15 EosFuse::lookup(fuse_req*, unsigned long, char const*) /afs/cern.ch/user/g/gbitzes/dev/eos/fusex/eosfuse.cc:1619 (eosxd+0x00000058c343)
    xrootd#16 <null> <null> (libfuse.so.2+0x000000016042)

[ ... ]

SUMMARY: ThreadSanitizer: data race /home/gbitzes/xrootd/src/XrdSys/XrdSysIOEvents.cc:1088 in XrdSys::IOEvents::Poller::TmoAdd(XrdSys::IOEvents::Channel*, int)
@apeters1971 apeters1971 mentioned this pull request Feb 21, 2018
Closed
@xrootd-dev xrootd-dev mentioned this pull request Mar 2, 2018
Closed
@osschar osschar mentioned this pull request Mar 6, 2018
Closed
@abh3 abh3 mentioned this pull request Apr 30, 2018
Closed
@osschar osschar mentioned this pull request Jun 25, 2018
Closed
@abh3 abh3 mentioned this pull request Aug 19, 2019
Closed
@apeters1971 apeters1971 mentioned this pull request Dec 3, 2019
Closed
This was referenced Jan 10, 2020
Closed
Closed
@wyang007 wyang007 mentioned this pull request Jun 19, 2020
Closed
@xrootd-dev xrootd-dev mentioned this pull request Jun 24, 2020
Closed
@abh3 abh3 mentioned this pull request Jul 15, 2020
Closed
@wyang007 wyang007 mentioned this pull request Oct 17, 2020
Closed
@xrootd-dev xrootd-dev mentioned this pull request Nov 2, 2020
Closed
@abh3 abh3 mentioned this pull request Jun 3, 2021
Merged
@abh3 abh3 mentioned this pull request Jan 18, 2022
Closed
@mdoidge mdoidge mentioned this pull request Feb 10, 2022
Closed
@abh3 abh3 mentioned this pull request Feb 11, 2022
Closed
@xrootd-dev xrootd-dev mentioned this pull request Nov 5, 2022
Closed
@xrootd-dev xrootd-dev mentioned this pull request Dec 1, 2022
Closed
@stlammel stlammel mentioned this pull request Dec 15, 2022
Closed
@andrejfilipcic andrejfilipcic mentioned this pull request Jan 11, 2023
Closed
@abh3 abh3 mentioned this pull request Mar 27, 2023
Closed
@abh3 abh3 mentioned this pull request Apr 10, 2023
Closed
amadio pushed a commit to amadio/xrootd that referenced this pull request May 12, 2023
@simonmichal
Merge pull request xrootd#9 from stfc/master
c00fc74 
Fix bug writing to an existing file with 'xrdcp -f' (xrootd/xrootd-ceph#1)
amadio pushed a commit to amadio/xrootd that referenced this pull request May 17, 2023
@snafus @amadio
Allow a delete to proceed if file is locked by removing the associate…
ac5d5df 
…d xattr metadata item. (xrootd#9)

In the case a file has an existing (stuck) lock, when the file is requested to be deleted, it will fail with -EBUSY. In this case we remove the lock and retry the unlink command.
This asserts therefore that a delete should take precedence over other activities.
As libradosstriper uses shared locks for both reads and writes, there is little chance to catch the few edge cases where this behaviour may be less desirable.
The lock removal is achieved through the removal of the lock extended attribute, using libradosstriper methods.

Co-authored-by: James Walder <james.walder@stfc.ac.uk>
@abh3 abh3 mentioned this pull request Oct 16, 2023
Closed
@smithdh smithdh mentioned this pull request Feb 1, 2024
Closed
@smithdh smithdh mentioned this pull request Mar 20, 2024
Closed
@smithdh smithdh mentioned this pull request Apr 26, 2024
Merged
amadio pushed a commit to amadio/xrootd that referenced this pull request Oct 30, 2024
@snafus @amadio
Allow a delete to proceed if file is locked by removing the associate…
70f51eb 
…d xattr metadata item. (xrootd#9)

In the case a file has an existing (stuck) lock, when the file is requested to be deleted, it will fail with -EBUSY. In this case we remove the lock and retry the unlink command.
This asserts therefore that a delete should take precedence over other activities.
As libradosstriper uses shared locks for both reads and writes, there is little chance to catch the few edge cases where this behaviour may be less desirable.
The lock removal is achieved through the removal of the lock extended attribute, using libradosstriper methods.

Co-authored-by: James Walder <james.walder@stfc.ac.uk>
amadio pushed a commit to amadio/xrootd that referenced this pull request Oct 31, 2024
@snafus @amadio
Allow a delete to proceed if file is locked by removing the associate…
8684367 
…d xattr metadata item. (xrootd#9)

In the case a file has an existing (stuck) lock, when the file is requested to be deleted, it will fail with -EBUSY. In this case we remove the lock and retry the unlink command.
This asserts therefore that a delete should take precedence over other activities.
As libradosstriper uses shared locks for both reads and writes, there is little chance to catch the few edge cases where this behaviour may be less desirable.
The lock removal is achieved through the removal of the lock extended attribute, using libradosstriper methods.

Co-authored-by: James Walder <james.walder@stfc.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug (critical)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlsalmon @ljanyst