Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facilitate triaging through automation #1226

Closed
guusdk opened this issue Oct 13, 2022 · 5 comments
Closed

Facilitate triaging through automation #1226

guusdk opened this issue Oct 13, 2022 · 5 comments
Labels
Editor Tooling Issue relates to process/tooling

Comments

@guusdk
Copy link
Contributor

guusdk commented Oct 13, 2022

Triaging is a manual process. It would be great to have a summary of things to manually watch out for as a comment by a bot in the PR.

@guusdk
Copy link
Contributor Author

guusdk commented Oct 13, 2022

@horazont (given that I've copied this suggestion from your email): would this be solved by a CI bot that would comment on every PR to this repository with a static text? If so, maybe a solution could be based on https://github.com/marketplace/actions/auto-comment

@horazont
Copy link
Contributor

That would be a start, yes.

Ideally combined with #1223.

@Echolon
Copy link
Member

Echolon commented Oct 25, 2022

Thank you Georg for the support!

  • Estimated workload: TBD
  • Assumption: TBD
  • Further clarification: What exactly is part of the triage? Is it simply about pre-build TODO-lists by the script?

@horazont
Copy link
Contributor

Basically, there should be a bot which implements all things which can be automated from https://github.com/xsf/xeps/blob/master/docs/TRIAGING.md#flowchart.

Example scenarios:

  • PR which adds a ProtoXEP to the inbox: the bot asks the Editor team to check for basic "publishability" (does not violate any XSF standard, e.g. by use obscene language)
  • PR which touches an Experimental XEP: the bot asks the Editor to either verify that the PR author is the author of the XEP (then it can be merged), or to ask the XEP author for confirmation
  • PR which touches a Stable XEP: the bot asks the Editor to check for editorial-only changes (can be merged) or to ask the approving body for confirmation.

Stuff like that. Just so that an Editor does not have to enter the diff view to find out which kind of further review.

@mwild1 mwild1 added the Editor Tooling Issue relates to process/tooling label Nov 4, 2022
@horazont
Copy link
Contributor

horazont commented Nov 5, 2022

Closed in favour of #1237, #1240, which should make for a clearer work package. Re-open here if you disagree or comment over there if you have anything to add.

@horazont horazont closed this as not planned Won't fix, can't repro, duplicate, stale Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editor Tooling Issue relates to process/tooling
Projects
None yet
Development

No branches or pull requests

4 participants