Create migrations #1
Conversation
XsidX
commented
Oct 20, 2022
•
XsidX
commented
- Create new Rails app
- Update database config
- Add ror and style linters
- Create users migration
- Create posts migration
- Create comments migration
- Create likes migration
- Run migrations
- Change user_id FK to author_id
There was a problem hiding this comment.
Hello @XsidX ,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
To highlight 💯
- Good commit message ✔️
- No Linter errors ✔️
- Follow Github flow ✔️
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me on @RolandM99 in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| create_table :posts do |t| | ||
| t.references :user, null: false, foreign_key: true |
There was a problem hiding this comment.
- Instead of using
user_idas theforeign-keyfor your tables, I suggest you useauthor_idto avoid a conflict that could arise if you use user_id with his index.
You can do it as below:
t.references :author, null: false, foreign_key: { to_table: 'users' } This will create author_id and a corresponding index
| class CreateComments < ActiveRecord::Migration[7.0] | ||
| def change | ||
| create_table :comments do |t| | ||
| t.references :user, null: false, foreign_key: true |
There was a problem hiding this comment.
- Instead of using
user_idas theforeign-keyfor your tables, I suggest you useauthor_idto avoid a conflict that could arise if you use user_id with his index.
You can do it as below:
t.references :author, null: false, foreign_key: { to_table: 'users' } This will create author_id and a corresponding index
| class CreateLikes < ActiveRecord::Migration[7.0] | ||
| def change | ||
| create_table :likes do |t| | ||
| t.references :user, null: false, foreign_key: true |
There was a problem hiding this comment.
- Kindly, Do the same as requested in the previous comment.
There was a problem hiding this comment.
Hello, @RolandM99
- Thanks for the heads up, the explanation is clear
There was a problem hiding this comment.
STATUS: APPROVED 💯
There is nothing else to say than it's time to merge... 🥳
Cheers and Happy coding! 👏 💻 🍷
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Optional suggestions
-N/A
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
Please be reminded to not open a new pull request after you get a review, only use the same one 💭
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
