Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions on the use of licensed materials #1

Open
mffap opened this issue Jun 2, 2023 · 1 comment
Open

Questions on the use of licensed materials #1

mffap opened this issue Jun 2, 2023 · 1 comment

Comments

@mffap
Copy link

mffap commented Jun 2, 2023

Appreciate the feedback and your time spend to improve the oidc library. I've had a quick look over some files and noticed some things with regards to how the original license is being used.

Under the Apache 2 license of the original source, you may reproduce and distribute copies of the work or derivative works. But certain conditions must be met, as outlined in §4 of the license.

Specifically my questions are

  • Do all modified files contain a prominent notice stating that you changed the files? (§4b)
  • Did you include the original NOTICE file, as is, to the repository? (§4d)

Since you've used a single commit strategy, the history of the contribution, thus also the attribution to those contributors is lost. Please take this into account for marking the modified files and including the notice to make attributions where these are due.

I love to see the library as foundations for other great projects, and hope the author also sees the open source values similar in providing the proper attributions to the people who worked on the library so far.

Thanks for the clarification.

@xslasd
Copy link
Owner

xslasd commented Jun 5, 2023

I apologize for any oversight on my part and my lack of understanding regarding licensing issues. My work was solely for learning purposes, and I redesigned and implemented some features based on the zitadel/oidc library. My entire framework is new, so there are no modifications or commit records. If there is any use of the source code, I am willing to mark the attribution. I will include a NOTICE file and welcome any suggestions for modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants