Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xslt): ignore xspec-utils.xsl in coverage trace listener #1014

Merged
merged 3 commits into from
Jun 25, 2020

Conversation

AirQuick
Copy link
Member

@AirQuick AirQuick commented Jun 22, 2020

The coverage trace listener does not exclude xspec-utils.xsl, which puts a burden on coverage reporters. (example)

  • 24c8045 adds a test which fails as expected.
  • 1630201 fixes the problem by excluding xspec-utils.xsl. Its logic is as primitive as the original exclusion of generate-tests-utils.xsl, yet I think it's slightly better than the current master.

@AirQuick AirQuick added the bug label Jun 22, 2020
@AirQuick AirQuick added this to the v2.0 milestone Jun 22, 2020
@AirQuick AirQuick marked this pull request as ready for review June 22, 2020 10:33
@AirQuick AirQuick merged commit 5de8a17 into xspec:master Jun 25, 2020
@AirQuick AirQuick deleted the ignore-xspec-utils-coverage branch June 25, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant