Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: detect duplicate function-param position #1266

Merged
merged 7 commits into from
Oct 5, 2020
Merged

fix: detect duplicate function-param position #1266

merged 7 commits into from
Oct 5, 2020

Conversation

AirQuick
Copy link
Member

@AirQuick AirQuick commented Oct 3, 2020 •
edited
Loading

Related to #1267

Like @name (#1063), duplicate @position should be rejected.

@AirQuick AirQuick added the test label Oct 3, 2020
@AirQuick AirQuick added this to the v2.0 milestone Oct 3, 2020
@AirQuick AirQuick mentioned this pull request Oct 3, 2020
Closed
@AirQuick AirQuick added bug and removed test labels Oct 3, 2020
galtm
galtm approved these changes Oct 4, 2020
View reviewed changes
Copy link
Member

@galtm galtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

I'm also glad to see your 4th bullet in the description of issue #1267 because the current treatment of mixtures of by-name and by-position parameters seems problematic.

@AirQuick AirQuick merged commit 6b3f090 into xspec:master Oct 5, 2020
@AirQuick AirQuick deleted the dup-param-position branch October 5, 2020 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galtm galtm galtm approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AirQuick @galtm