Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(xquery): credit for functx:capitalize-first() #1305

Merged
merged 1 commit into from
Dec 7, 2020
Merged

docs(xquery): credit for functx:capitalize-first() #1305

merged 1 commit into from
Dec 7, 2020

Conversation

AirQuick
Copy link
Member

@AirQuick AirQuick commented Dec 6, 2020

tutorial/xquery-tutorial.xqm takes a function from FunctX XQuery library without mentioning it.
This pull request adds its source URL, just like tutorial/escape-for-regex.xsl.

(Strictly speaking, I guess we should attach its license or use our original function.)

@AirQuick AirQuick added this to the v2.1 milestone Dec 6, 2020
@cirulls cirulls self-requested a review December 7, 2020 15:24
cirulls
cirulls approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@cirulls cirulls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I think it's fine to put a link to the URL since the web page mentions that the code is available under the GNU LGPL license.

@AirQuick AirQuick merged commit cc9bf8f into xspec:master Dec 7, 2020
@AirQuick AirQuick deleted the credit-xquery-tutorial branch December 7, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cirulls cirulls cirulls approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AirQuick @cirulls