feat: do not allow x:variable to override x:param #1330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
@run-as="external"
, only/x:description/x:param
is supposed to take effect in SUT.x:variable
is not.However,
x:variable
can overridex:param
and effectively go into SUT. For example:With this stylesheet
and this XSpec
get-p
returnslocal-p
, notglobal-p
, becausex:variable
overrides the value of$p
.get-v
returns''
, becausex:variable
by itself does not take effect in SUT.This behavior could be considered as "by design". (In that sense, #991 is already partially possible. 😀)
But I think it's confusing. So this pull request prohibits
x:variable
from overriding/x:description/x:param
. With this change, the example above is terminated with an error:Upon implementing #991, I'll extend this rule and prohibit
x:variable
from overriding//x:scenario/x:param
as well.