fix(cli): properly detect XSPEC_HOME #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AirQuick
changed the title
|
Thanks for finding and fixing the issue. |
mcwayliffe
force-pushed
the
xspec-home-detection
branch
from
dd7f377
to
268f0d0
Compare
|
@mcwayliffe Now I added a regression test 72d0105 to your branch. Does it look good to you? If so (or if you don't care about the test), I'll merge this pull request. |
|
@AirQuick LGTM 👍 |
AirQuick
approved these changes
Nov 19, 2021
There was a problem hiding this comment.
Though I'm not very familiar with shell scripts, the fix looks good according to https://unix.stackexchange.com/a/118438.
I'm merging this (after integrating the current master in order to fulfill the required statuses).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
$(dirname "$0")is not a safe way to get the location of a running script.For example, if you run:
the value of
XSPEC_HOMEwill be.. Not what you want. More reliable tocd && pwd