fix: declare function-param and template-param using internal name #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galtm
approved these changes
Dec 5, 2021
|
Thanks @galtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1564
This pull request fixes a bug where
//(x:call | x:context)/x:param[@name]can be referenced inadvertently outside its scope ("Test 3" of #1564 (comment)).Before fixing the bug,
//(x:call | x:context)/x:param[@name]was transformed intoxsl:variableusing its@name.After this fix, it is transformed using an internal name. Hence the test author is no longer able to refer to the declared variable. I guess nobody is affected by that. The tests for that "feature" are removed by a commit 4d7e210.