Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schematron): bump built-in SchXslt to v1.9.3 #1664

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

AirQuick
Copy link
Member

Replace the built-in SchXslt v1.8.6 with v1.9.3.

Note that the base branch of this pull request is not master but schxslt.

@AirQuick AirQuick added this to the v2.3 milestone Sep 25, 2022
Copy link
Member

@galtm galtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filled in my background a bit by looking at #1366 and #1380 . Looks like you copied in the changes from the schxslt repo, except that version.xsl has a hard-coded SchXSLT version number because ${project.version} as in the schxslt repo's file won't work outside its own environment. Do I understand this correctly?

@github-actions github-actions bot force-pushed the schxslt branch 2 times, most recently from 964baee to cd1e28c Compare October 17, 2022 00:34
@AirQuick
Copy link
Member Author

AirQuick commented Oct 17, 2022

Thanks for reviewing this, @galtm.
As noted in README.md, the files in lib/schxslt/ are always taken from the xslt-only distribution files of SchXslt. (More specifically, this pr took https://github.com/schxslt/schxslt/releases/download/v1.9.3/schxslt-1.9.3-xslt-only.zip.)

@AirQuick AirQuick merged commit 917116e into xspec:schxslt Oct 17, 2022
@AirQuick AirQuick deleted the schxslt branch October 17, 2022 04:42
AirQuick added a commit to AirQuick/xspec that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants