Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: bats_require_minimum_version 1.5.0 #1694

Merged
merged 1 commit into from
Mar 10, 2023
Merged

test: bats_require_minimum_version 1.5.0 #1694

merged 1 commit into from
Mar 10, 2023

Conversation

AirQuick
Copy link
Member

This pr addresses BW02 warnings from Bats:
https://github.com/xspec/xspec/actions/runs/4262150688/jobs/7417307594#step:3:28

BW02: Using flags on run requires at least BATS_VERSION=1.5.0. Use bats_require_minimum_version 1.5.0 to fix this message.`

Details are in https://bats-core.readthedocs.io/en/stable/warnings/BW02.html

@AirQuick AirQuick added the test label Feb 24, 2023
@AirQuick AirQuick added this to the v2.3 milestone Feb 24, 2023
galtm
galtm approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@galtm galtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! It looks good. Do you want me to merge it in, or would you rather do that?

@galtm galtm merged commit 65c954c into xspec:master Mar 10, 2023
@AirQuick AirQuick deleted the require-bats-1-5-0 branch April 26, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galtm galtm galtm approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
v2.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AirQuick @galtm