Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test with Java 17 #1714

Merged
merged 3 commits into from
May 1, 2023
Merged

ci: test with Java 17 #1714

merged 3 commits into from
May 1, 2023

Conversation

AirQuick
Copy link
Member

@AirQuick AirQuick commented Apr 30, 2023

This pull request replaces Java 11 with Java 17 in the test matrix of GitHub Actions and Azure Pipelines.
While working on this, I noticed cleanDestinationDirectory was no longer necessary. (Probably fixed by microsoft/azure-pipelines-tasks#13657.) 60b46b0 removes it.

Why

The latest version of Java LTS is 17.
Also, Oxygen 24+ is shipped with 17.

Further work

Update Wiki.

@AirQuick AirQuick added the test label Apr 30, 2023
@AirQuick AirQuick added this to the v2.3 milestone Apr 30, 2023
Copy link
Member

@galtm galtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming all the tests pass, this looks like a good update to make. Thanks!

@AirQuick AirQuick enabled auto-merge (squash) May 1, 2023 01:46
@AirQuick
Copy link
Member Author

AirQuick commented May 1, 2023

Further work

Update Wiki.

Done.

@AirQuick
Copy link
Member Author

AirQuick commented May 1, 2023

Updated the master branch protection rule to reflect this change.

@AirQuick AirQuick merged commit 362318b into master May 1, 2023
@AirQuick AirQuick deleted the test_java-17 branch May 1, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants