Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: replace Log4j with SLF4J Simple #1720

Merged
merged 4 commits into from
May 5, 2023
Merged

Conversation

AirQuick
Copy link
Member

@AirQuick AirQuick commented May 3, 2023

Following #1658, this pull request just replaces Log4j with slf4j-simple.
slf4j-simple requires fewer files and seems to be more compatible with XML Resolver, one of the lib files used by XML Calabash.

@AirQuick AirQuick added this to the v2.3 milestone May 3, 2023
Copy link
Member

@galtm galtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, I ran the bats test on Windows on a local branch that has your changes in this pull request plus my Saxon 11.5 changes for #1717 . There were no failures.

test/ci/env/global.env Outdated Show resolved Hide resolved
@AirQuick AirQuick enabled auto-merge (squash) May 5, 2023 17:46
@AirQuick AirQuick merged commit 06b05c5 into xspec:master May 5, 2023
@AirQuick AirQuick deleted the slf4j-simple branch May 5, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants