Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move code to avoid conflict in schxslt rebase #1853

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

galtm
Copy link
Member

@galtm galtm commented Jan 20, 2024

This PR toward the master branch just moves the code added in #1780 to a different spot in the file relative to the Bad Schematron @location section.

The schxslt automatic rebase wants to delete the SVRL @location fails to select text node #396 test case within the Bad Schematron @location section. Keeping it at the same location of the file where it had been (before #1780) might avoid recurring merge conflicts during the rebase operation.

@galtm galtm added this to the v3.0 milestone Jan 20, 2024
The schxslt automatic rebase wants to delete a test
case that is at the end of the file. Keep that code at
the end to try to avoid recurring merge conflicts
during the rebase operation.
@galtm galtm merged commit dc01ad4 into xspec:master Jan 20, 2024
38 checks passed
@galtm
Copy link
Member Author

galtm commented Jan 20, 2024

The rebase went smoothly. :)
https://github.com/xspec/xspec/actions/runs/7596630591/job/20690553233

+ git rebase origin/master
Rebasing (1/3)
Rebasing (2/3)
Rebasing (3/3)

                                                                                
Successfully rebased and updated refs/heads/schxslt.

Also, the content of xspec.bats and collection.xml on the schxslt branch looks as expected.
https://github.com/xspec/xspec/blob/schxslt/test/xspec.bats
https://github.com/xspec/xspec/blob/schxslt/test/win-bats/collection.xml

@galtm galtm deleted the move-bats-cases branch January 20, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant