Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schematron): allow variables in Schematron scenario #1873

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

galtm
Copy link
Member

@galtm galtm commented Mar 9, 2024

I don't think there is any good reason for Schematron scenarios not to support XSpec variables. Omitting variable from the schematron-scenario pattern was probably just an oversight on my part when I worked on #475. The rest of the code seems to handle variables in Schematron test just fine.

This PR updates the schema to allow variables in Schematron scenarios and adds some tests.

@galtm galtm added this to the v3.0 milestone Mar 9, 2024
@galtm galtm changed the title schema(schematron): allow variables in Schematron scenario feat(schematron): allow variables in Schematron scenario Mar 9, 2024
@galtm galtm requested review from AirQuick and vincentml March 9, 2024 16:43
@galtm galtm enabled auto-merge (squash) March 19, 2024 13:05
@galtm galtm merged commit 1d91305 into xspec:master Mar 19, 2024
37 of 38 checks passed
@galtm galtm deleted the schematron-with-variables branch March 19, 2024 17:18
@galtm
Copy link
Member Author

galtm commented Mar 19, 2024

The continuous-integration/appveyor/pr testing timed out three times, during the end-to-end testing phase. I checked in the latest log that the bats test ended with EXIT_CODE=0 and the non-end-to-end tests had only failed: 0. Some of the end-to-end tests are supposed to have failures. I doubt that whichever end-to-end tests didn't get run would have told us something new that the other two testing environments wouldn't have caught. AppVeyor testing sometimes takes around 45-55 minutes but times out occasionally.

At least temporarily, I removed "continuous-integration/appveyor/pr " from the list of required checks in the master branch protection rule.

@galtm
Copy link
Member Author

galtm commented Mar 19, 2024

AppVeyor passed all tests for #1838 (in only 46 min 52 sec), which was after this PR was already merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant