fix: pending x:expect should not trigger running SUT #1876
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was doing some experiments with
@catch
to pinpoint the latest spot wherecatch="yes"
needs to go if you want to avoid a hard error when running a test whose SUT produces an error. It seemed like a bug that a pendingx:expect
element caused the SUT to run. I expected a pendingx:expect
element not to influence test behavior at all.This PR changes the logic for what causes the SUT to run from "this scenario isn't pending and has at least one
x:expect
child" to "this scenario isn't pending and has at least onex:expect
child that also isn't pending."Example of effect on test-driven development
On the master branch, the first scenario has a hard error, while the second scenario runs to completion.
On the branch of this PR, both scenarios run to completion. The first scenario is similar to the
catch.xspec
addition in this PR.