end-to-end test for JUnit report #210
Conversation
| </html> |
There was a problem hiding this comment.
Probably 75048a9 is an accidental commit and should be reverted?
There was a problem hiding this comment.
I've reverted this change. When I rebased the branch I had been trying a new text editor and it had an unexpected default setting to automatically reformat whitespace.
| xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:xsl="http://www.w3.org/1999/XSL/Transform"> | ||
|
|
||
| <!-- output serialization parameters should be in line with XSPEC_HOME/src/reporter/junit-report.xsl --> | ||
| <xsl:output name="junit" method="xml" omit-xml-declaration="yes" indent="yes"/> |
There was a problem hiding this comment.
I think this xsl:output should be just <xsl:output name="junit"/>.
XSPEC_HOME/src/reporter/junit-report.xsl has xsl:output with @indent etc, but it has name="escaped" which is not referenced. The serialization parameter is thus effectively <xsl:output/>.
There was a problem hiding this comment.
Agreed, I've made this change.
The xsl:output declaration in junit-report.xsl could probably be removed or shortened to <xsl:output/>.
…ch had just added a new line at the end of a file This reverts commit 75048a9.
…line with the effective output serialization parameters of XSPEC_HOME/src/reporter/junit-report.xsl
|
Thanks, @vincentml , I tested as follows. Looks good to me. On Windows:
On Linux:
On Windows and Linux:
|
|
I'll merge this in a few days. |
|
@cirulls |
This pull request adds end-to-end tests for JUnit report output from XSpec.
This is step 2 of the plan as suggested by @AirQuick