Simplify test case in xspec-bat.cmd (ifdef) #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…185_cumulative # Conflicts: # test/xspec.bats
# Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…185_cumulative # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
# Conflicts: # test/xspec-bat.cmd # test/xspec.bats
This was referenced Oct 15, 2018
…185_cumulative # Conflicts: # build.xml
…185_cumulative # Conflicts: # test/saxon-custom-options/config.xml # test/saxon-custom-options/test.xspec # test/xspec-bat.cmd # test/xspec.bats
# Conflicts: # build.xml # test/saxon-custom-options/config.xml # test/saxon-custom-options/test.xspec # test/xspec-bat.cmd # test/xspec.bats
…185_cumulative # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
# Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…185_cumulative # Conflicts: # build.xml
# Conflicts: # build.xml
…185_cumulative # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
# Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…k/xspec into case-ifdef # Conflicts: # test/xspec-bat.cmd
# Conflicts: # test/xspec-bat.cmd
# Conflicts: # test/xspec-bat.cmd # test/xspec-bat/README.md # test/xspec-bat/stub.cmd
# Conflicts: # test/xspec-bat/collection.xml # test/xspec-bat/collection.xsd # test/xspec-bat/generate.xsl
cirulls
approved these changes
Dec 4, 2018
There was a problem hiding this comment.
This looks good to me. I reviewed it as follows:
- I followed the instructions to create a diff as in the previous pull request and checked that all the tests were covered in the new implementation.
- I ran the test suite locally, all tests are green. I intentionally broke a test and the test failure was correctly picked up.
- I inspected the link provided and the code. It's definitely easier to follow what the tests does via the attribute
ifdefand the use of environment variables.
I'm merging this into master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request derives from #285. So needs to be handled after that.
To skip some test cases in the batch script, you have to write
ifandcall :skipand manage the scope of(and).This pull request simplifies it. Just write
@ifdefand it will be expanded as batch script.With this pull request and #285, the batch script decreases cleanly: 718 lines to 475 lines
On AppVeyor, you can see all tests run and some are skipped appropriately. With a temporary commit (b2bf80e), you can see test failures are still detected.
Although the diff looks large due to indentation, this pull request is in fact a simple change. You can confirm it easily:
xspec-bat.cmdusing the current master.xspc-bat~TEMP~.cmdsomewhere and keep it.xspec-bat.cmdusing this pull request.xspc-bat~TEMP~.cmdwith the one you kept. They should look almost the same.