Align bats tests #291
Align bats tests #291
Conversation
…185_cumulative # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…-tests # Conflicts: # .travis.yml # appveyor.yml # test/xspec-bat.cmd # test/xspec.bats
…185_cumulative # Conflicts: # build.xml
…185_cumulative # Conflicts: # test/saxon-custom-options/config.xml # test/saxon-custom-options/test.xspec # test/xspec-bat.cmd # test/xspec.bats
…-tests # Conflicts: # build.xml # test/saxon-custom-options/config.xml # test/saxon-custom-options/test.xspec # test/xspec-bat.cmd # test/xspec.bats
…185_cumulative # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…-tests # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…185_cumulative # Conflicts: # build.xml
…-tests # Conflicts: # build.xml # test/run-xspec-tests-ant.cmd # test/run-xspec-tests-ant.sh
…-tests # Conflicts: # test/end-to-end/generate-expected.cmd # test/end-to-end/generate-expected.sh # test/end-to-end/run-e2e-tests.cmd # test/end-to-end/run-e2e-tests.sh
…185_cumulative # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…-tests # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…k/xspec into align-bats-tests # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…-tests # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…-tests # Conflicts: # test/.gitignore # test/xspec-bat.cmd
…-tests # Conflicts: # test/win-bats/collection.xml # test/xspec.bats
There was a problem hiding this comment.
This looks good to me, thanks for tyding up the code. I reviewed it by inspecting the code and checking that the changes are cosmetic and do not impact the tests or the code logic.
I'm merging this into master.
Just two comments:
-
I can see this test for Windows was added but it is never executed:
<!-- bin\xspec.bat does not support saxon script --> <case ifdef="NEVER" name="invoking xspec with saxon script uses the saxon script #121 #122">
I guess this is just to align the tests on Windows and Linux/MacOS. I'm absolutely fine with that, I just wanted to mention it in case I misunderstood it.
-
I am probably the one to blame for introducing inconsistent indentation in the shell scripts. One thing I would like to do in the future is to introduce some code styling checks (things like 4 spaces for indentation, etc.) so that we have some consistent code styling in the code base and this is checked automatically by the CI. This is just an idea but it would prevent sloppy contributors like to me to commit inconsistent spacing 😉
Exactly. |
This pull request derives from #289. So needs to be handled after that.
This pull request just aligns the bats test scripts. The changes are trivial (name, indent). All the tests are virtually kept intact.
This change makes it easier to compare the scripts.