Fix xspec.bat to accommodate 11+ params #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…185_cumulative # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…-tests # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…aramater # Conflicts: # build.xml # test/saxon-custom-options/config.xml # test/saxon-custom-options/test.xspec # test/xspec-bat.cmd # test/xspec.bats
…arams_cumulative # Conflicts: # build.xml # test/saxon-custom-options/config.xml # test/saxon-custom-options/test.xspec # test/xspec-bat.cmd # test/xspec.bats
…185_cumulative # Conflicts: # build.xml
…-tests # Conflicts: # build.xml # test/run-xspec-tests-ant.cmd # test/run-xspec-tests-ant.sh
…-tests # Conflicts: # test/end-to-end/generate-expected.cmd # test/end-to-end/generate-expected.sh # test/end-to-end/run-e2e-tests.cmd # test/end-to-end/run-e2e-tests.sh
…aramater # Conflicts: # build.xml # test/end-to-end/generate-expected.cmd # test/end-to-end/generate-expected.sh # test/end-to-end/run-e2e-tests.cmd # test/end-to-end/run-e2e-tests.sh # test/run-xspec-tests-ant.cmd # test/run-xspec-tests-ant.sh
…arams_cumulative # Conflicts: # build.xml # test/end-to-end/generate-expected.cmd # test/end-to-end/generate-expected.sh # test/end-to-end/processor/html/_normalizer.xsl # test/end-to-end/run-e2e-tests.cmd # test/end-to-end/run-e2e-tests.sh # test/run-xspec-tests-ant.cmd # test/run-xspec-tests-ant.sh
…185_cumulative # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…-tests # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…aramater # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…arams_cumulative # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…k/xspec into align-bats-tests # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…-tests # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…into fix_typo-Paramater
…into fix_many-params_cumulative
…arams_cumulative # Conflicts: # test/win-bats/collection.xml # test/xspec.bats
|
I know this is a busy time of year. If no concern arises in 72 hours, I'd like to merge this anyway because it's low-risk and has tests. (Actually 300+ days have already passed without any concern since the change was first submitted.) |
cirulls
approved these changes
Dec 20, 2018
There was a problem hiding this comment.
This looks good to me. I tested it as follows:
- I replicated the bug on the current master branch, running the command in the test on Windows returns
Error: file not found. - I executed the command in the test on Windows on the branch of this pull request, it returns the usage help.
- I ran the test suite on both Windows and Linux and checked that the new test was picked up and executed.
I'm merging this into master (sorry for the wait).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request derives from #293. So needs to be handled after that.
xspec.bat(the command line for Windows) drops the 11th+ arguments.This pull request
You can see the test fails on AppVeyor before committing the fix.
You can see it takes effect on AppVeyor.
As a bonus, we now have a test for
-h.