Comment out pending invalid scenario in xspec-rule.xspec #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c-rule # Conflicts: # test/xspec-bat.cmd
…185_cumulative # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…c-rule # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…185_cumulative # Conflicts: # test/xspec.bats
…c-rule # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…c-rule # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…c-rule # Conflicts: # .travis.yml # appveyor.yml # bin/xspec.bat # test/xspec-bat.cmd # test/xspec.bats
…185_cumulative # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…185_cumulative # Conflicts: # build.xml
…185_cumulative # Conflicts: # test/saxon-custom-options/config.xml # test/saxon-custom-options/test.xspec # test/xspec-bat.cmd # test/xspec.bats
…185_cumulative # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…c-rule # Conflicts: # build.xml # test/saxon-custom-options/config.xml # test/saxon-custom-options/test.xspec # test/xspec-bat.cmd # test/xspec.bats
…k/xspec into valid-xspec-rule # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…c-rule # Conflicts: # build.xml # test/end-to-end/generate-expected.cmd # test/end-to-end/generate-expected.sh # test/end-to-end/processor/html/_normalizer.xsl # test/end-to-end/run-e2e-tests.cmd # test/end-to-end/run-e2e-tests.sh # test/run-xspec-tests-ant.cmd # test/run-xspec-tests-ant.sh
…c-rule # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…c-rule # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…c-rule # Conflicts: # test/run-bats.cmd # test/run-bats.sh # test/win-bats/collection.xml # test/xspec.bats
…c-rule # Conflicts: # test/win-bats/collection.xml # test/xspec.bats
…c-rule # Conflicts: # bin/xspec.bat
|
@cirulls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request derives from #303. So needs to be handled after that.
Two scenarios in
xspec-rule.xspecare invalid in terms of schema (#60).They are disabled by
pendingattributes. And in this case, thependingattributes are not being tested. (On the other hand,pendingattributes inxspec-pending.xspecare actually tested.) So, we can comment out those two scenarios safely.This pull request comments out the scenarios and inserts
TODOcomments describing what to do before activating them. Nowxspec-rule.xspecis valid in terms of schema.