Revise risky test attributes in tests #320

AirQuick · 2018-08-31T11:49:31Z

This pull request derives from #319. So needs to be handled after that.

If you break generate-xspec-tests.xsl intentionally (16ae511), generate-xspec-tests.xspec must fail. But actually it doesn't fail. (Travis)

The test doesn't fail, because the expression in x:expect/@test can be an empty sequence. This is a common mistake in writing @test.

This pull request revises tests in test/ to avoid the same kind of risky expressions.

…c-rule

…oolean-test # Conflicts: # .travis.yml # appveyor.yml # bin/xspec.bat # test/xspec-bat.cmd # test/xspec.bats

…185_cumulative # Conflicts: # build.xml

…185_cumulative # Conflicts: # test/saxon-custom-options/config.xml # test/saxon-custom-options/test.xspec # test/xspec-bat.cmd # test/xspec.bats

…185_cumulative # Conflicts: # test/xspec-bat.cmd # test/xspec.bats

…c-rule # Conflicts: # build.xml # test/saxon-custom-options/config.xml # test/saxon-custom-options/test.xspec # test/xspec-bat.cmd # test/xspec.bats

…oolean-test # Conflicts: # build.xml # test/saxon-custom-options/config.xml # test/saxon-custom-options/test.xspec # test/xspec-bat.cmd # test/xspec.bats

…k/xspec into valid-xspec-rule # Conflicts: # test/xspec-bat.cmd # test/xspec.bats

…c-rule # Conflicts: # build.xml # test/end-to-end/generate-expected.cmd # test/end-to-end/generate-expected.sh # test/end-to-end/processor/html/_normalizer.xsl # test/end-to-end/run-e2e-tests.cmd # test/end-to-end/run-e2e-tests.sh # test/run-xspec-tests-ant.cmd # test/run-xspec-tests-ant.sh

…oolean-test # Conflicts: # build.xml # test/end-to-end/generate-expected.cmd # test/end-to-end/generate-expected.sh # test/end-to-end/processor/html/_normalizer.xsl # test/end-to-end/run-e2e-tests.cmd # test/end-to-end/run-e2e-tests.sh # test/run-xspec-tests-ant.cmd # test/run-xspec-tests-ant.sh

…c-rule # Conflicts: # test/xspec-bat.cmd # test/xspec.bats

…oolean-test # Conflicts: # test/xspec-bat.cmd # test/xspec.bats

…c-rule # Conflicts: # test/xspec-bat.cmd # test/xspec.bats

…into explicit-boolean-test # Conflicts: # test/xspec.bats

…oolean-test # Conflicts: # .travis.yml # appveyor.yml # test/run-bats.cmd # test/run-bats.sh # test/win-bats/collection.xml # test/xspec.bats

…oolean-test

…oolean-test # Conflicts: # src/compiler/generate-xspec-tests.xsl # test/end-to-end/cases/xspec-focus-1.xspec # test/end-to-end/cases/xspec-function.xspec # test/end-to-end/cases/xspec-import.xspec # test/end-to-end/cases/xspec-imported.xspec # test/end-to-end/cases/xspec-pending.xspec # test/generate-tests-utils.xspec # test/generate-x-utils.xspec # test/generate-xspec-tests.xspec # test/xspec-focus-2.xspec # test/xspec-variable.xspec

…oolean-test

AirQuick · 2019-01-26T14:05:22Z

@cirulls
Merged this PR which just hardens some x:expect expressions in test files. Nothing has changed in essence.

As mentioned in #506, this is the last PR of mine for v1.2.0 at the moment. Some other candidates you may want to resolve for v1.2.0 can be found in the project board.

@galtm
This change again incurred a conflict in #475. I hope you can resolve it easily.
The only intent of this change is to rectify @test expressions in files in test/ which satisfy both of the following conditions:

The test author expects @test to be either true or false
Actually the @test can result in an empty sequence

galtm · 2019-01-27T16:59:24Z

@AirQuick
Thanks for the tip. I adapted my code in this commit: fea377c

By the way, in test/generate-xspec.xspec, you changed test="$t:result/t:scenario/t:label eq 'my label'" to test="$t:result/t:scenario/t:label/string()" select="'my label'". When I tried doing something similar in my code in xspec-variable.xspec in my PR#475, it worked in XSLT but not in XQuery. I'm mentioning that just in case it's not what you expected the XQuery implementation to do.

What I did instead in some spots was test for node existence in addition to checking values. If you have a better idea, I'm open to suggestions.

AirQuick · 2019-01-28T07:04:59Z

Thanks for the update. Unfortunately x:expect[@test][@select] doesn't work now (#440). I think your approach is good and sufficient for now.

galtm · 2019-01-28T13:06:18Z

OK, glad the XQuery behavior was at least already known.

AirQuick added 30 commits August 2, 2018 09:59

Check Ant test results more closely

cb85346

Double quote environment variable lines

e4b5629

Enable echo new line in xspec.bats

491a8ac

Copy silently and fail on error

59752e7

Allow XML_RESOLVER_CP to be any name

303cfbb

Use work dir in xspec.bats

3e7f9a4

Use work dir in xspec-bat.cmd

3f09e1b

Add missing XQuery tests

4338907

Add comments

8db0d87

Set ANT_VERSION

159e6cc

Verify line count

473589f

Sort mkdir and rmdir lines in alphabetical order

cabaeca

Remove redundant ../test/

d5685e5

Remove redundant spaces after =~

03c08f8

Rename APOSTROPHE_DIR to SPECIAL_CHARS_DIR

96d6b9b

Adjust BaseX command line syntax to example in Wiki

32bc4f1

Check default compiled-file

db39489

Set compiled-file

0794bed

Add test for xspec.properties

3e377dc

Check the actual result of DEL and RMDIR

039980f

Delete Schematron temp files

37a7e59

Verify and delete Schematron temp files at the same time

71e669a

Replace stat with test

7d46c63

Consolidate -j tests

138c6b4

Consolidate default report file tests

8c3f418

Consolidate default HTML report file tests

9fe575a

Consolidate HTML report file inspection

0e93d9a

Remove redundant echo

67a9e03

Use demo-03 instead of demo-01

251e845

Consolidate -s tests

d8b39b6

AirQuick added 17 commits October 15, 2018 18:55

Merge branch 'master' of git://github.com/xspec/xspec into valid-xspe…

0ea4a27

…c-rule

Merge branch 'master' of git://github.com/xspec/xspec into explicit-b…

e98268b

…oolean-test # Conflicts: # .travis.yml # appveyor.yml # bin/xspec.bat # test/xspec-bat.cmd # test/xspec.bats

Merge branch 'master' of git://github.com/xspec/xspec into fix_issue-…

e2d3079

…185_cumulative # Conflicts: # build.xml

Merge branch 'master' of git://github.com/xspec/xspec into fix_issue-…

6c7f860

…185_cumulative # Conflicts: # test/saxon-custom-options/config.xml # test/saxon-custom-options/test.xspec # test/xspec-bat.cmd # test/xspec.bats

Merge branch 'master' of git://github.com/xspec/xspec into fix_issue-…

dcbd661

…185_cumulative # Conflicts: # test/xspec-bat.cmd # test/xspec.bats

Merge branch 'master' of git://github.com/xspec/xspec into valid-xspe…

75d7fee

…c-rule # Conflicts: # build.xml # test/saxon-custom-options/config.xml # test/saxon-custom-options/test.xspec # test/xspec-bat.cmd # test/xspec.bats

Merge branch 'master' of git://github.com/xspec/xspec into explicit-b…

e33226c

…oolean-test # Conflicts: # build.xml # test/saxon-custom-options/config.xml # test/saxon-custom-options/test.xspec # test/xspec-bat.cmd # test/xspec.bats

Suppress sorting more thoroughly and clearly

91e354d

Merge branch 'fix_issue-185_cumulative' of https://github.com/AirQuic…

e0df043

…k/xspec into valid-xspec-rule # Conflicts: # test/xspec-bat.cmd # test/xspec.bats

Merge branch 'master' of git://github.com/xspec/xspec into valid-xspe…

ba80792

…c-rule # Conflicts: # test/xspec-bat.cmd # test/xspec.bats

Merge branch 'master' of git://github.com/xspec/xspec into explicit-b…

1c52587

…oolean-test # Conflicts: # test/xspec-bat.cmd # test/xspec.bats

Merge branch 'master' of git://github.com/xspec/xspec into valid-xspe…

f90625c

…c-rule # Conflicts: # test/xspec-bat.cmd # test/xspec.bats

Merge branch 'valid-xspec-rule' of https://github.com/AirQuick/xspec …

fea6a53

…into explicit-boolean-test # Conflicts: # test/xspec.bats

Merge branch 'master' of git://github.com/xspec/xspec into explicit-b…

ea0c162

…oolean-test # Conflicts: # .travis.yml # appveyor.yml # test/run-bats.cmd # test/run-bats.sh # test/win-bats/collection.xml # test/xspec.bats

Merge branch 'master' of git://github.com/xspec/xspec into explicit-b…

b728945

…oolean-test

AirQuick added this to the v1.2.0 milestone Jan 25, 2019

AirQuick added 2 commits January 26, 2019 00:08

Merge branch 'master' of git://github.com/xspec/xspec into explicit-b…

345ad49

…oolean-test

AirQuick merged commit 0456f53 into xspec:master Jan 26, 2019

AirQuick deleted the explicit-boolean-test branch January 26, 2019 13:29

AirQuick mentioned this pull request Feb 4, 2019

Release v1.2.0 #506

Closed

AirQuick mentioned this pull request Aug 28, 2019

Add x:variable to schema and improve compiler support for x:variable #475

Merged

cirulls mentioned this pull request Sep 5, 2019

Automatically generate release notes #601

Closed

AirQuick mentioned this pull request Sep 14, 2020

test: harden risky attribute(test) #1236

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revise risky test attributes in tests #320

Revise risky test attributes in tests #320

AirQuick commented Aug 31, 2018

AirQuick commented Jan 26, 2019 •

edited

Loading

galtm commented Jan 27, 2019

AirQuick commented Jan 28, 2019

galtm commented Jan 28, 2019

Revise risky test attributes in tests #320

Revise risky test attributes in tests #320

Conversation

AirQuick commented Aug 31, 2018

AirQuick commented Jan 26, 2019 • edited Loading

galtm commented Jan 27, 2019

AirQuick commented Jan 28, 2019

galtm commented Jan 28, 2019

AirQuick commented Jan 26, 2019 •

edited

Loading