Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for base URI #347

Merged
merged 501 commits into from
Mar 1, 2019
Merged

Test for base URI #347

merged 501 commits into from
Mar 1, 2019

Conversation

AirQuick
Copy link
Member

This pull request derives from #345. So needs to be handled after that.


This pull request just adds some tests to ensure that the external files such as x:import/@href are loaded via the base URI.

…a-aware_ant

# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
…ne-coverage

# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
…overage

# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
…-215

# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
…talog

# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
…talog

# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
…xpected-uri

# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
…ntext

# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
…177_cumulative

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	test/xspec-bat.cmd
#	test/xspec.bats
…c-rule

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	bin/xspec.bat
#	test/xspec-bat.cmd
#	test/xspec.bats
…211_cumulative

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	bin/xspec.bat
#	test/xspec-bat.cmd
#	test/xspec.bats
…ntext

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	bin/xspec.bat
#	test/xspec-bat.cmd
#	test/xspec.bats
…eport

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	bin/xspec.bat
#	test/xspec-bat.cmd
#	test/xspec.bats
…l-uri

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	bin/xspec.bat
#	test/xspec-bat.cmd
#	test/xspec.bats
…185_cumulative

# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
…-tests

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	test/xspec-bat.cmd
#	test/xspec.bats
…overage

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	bin/xspec.bat
#	test/xspec-bat.cmd
#	test/xspec.bats
…ne-coverage

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	bin/xspec.bat
#	test/xspec-bat.cmd
#	test/xspec.bats
…-bats

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	bin/xspec.bat
#	test/xspec-bat.cmd
#	test/xspec.bats
# Conflicts:
#	.travis.yml
#	appveyor.yml
#	bin/xspec.bat
#	test/xspec-bat.cmd
#	test/xspec.bats
…xpected-uri

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	bin/xspec.bat
#	test/xspec-bat.cmd
#	test/xspec.bats
…talog

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	bin/xspec.bat
#	test/xspec-bat.cmd
#	test/xspec.bats
…talog

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	bin/xspec.bat
#	test/xspec-bat.cmd
#	test/xspec.bats
…-215

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	bin/xspec.bat
#	test/xspec-bat.cmd
#	test/xspec.bats
…177_cumulative

# Conflicts:
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.html
#	test/end-to-end/cases/expected/xspec-rule-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/generate-tests-utils.xspec
#	test/win-bats/collection.xml
#	test/xspec.bats
# Conflicts:
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.html
#	test/end-to-end/cases/expected/xspec-rule-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/generate-tests-utils.xspec
#	test/win-bats/collection.xml
#	test/xspec.bats
@AirQuick AirQuick added this to the v1.3.0 milestone Feb 11, 2019
…177_cumulative

# Conflicts:
#	test/end-to-end/cases/expected/schematron/schematron-01-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-153-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-ambiguous-expect-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-focus-1-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-function-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-import-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-pending-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-xslt2-result.xml
@AirQuick AirQuick requested a review from galtm February 26, 2019 07:26
@AirQuick
Copy link
Member Author

@galtm
Can you take a look at this change?
This change just ensures that various instances of @href are resolved with @xml:base.

Also, I think x:variable has @href. After merging this, please consider integrating x:variable into xml-base.xspec in #475, like you have already done in xspec-node-selection.xspec.

Copy link
Member

@galtm galtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@AirQuick AirQuick merged commit 6706a3f into xspec:master Mar 1, 2019
@AirQuick AirQuick deleted the test_xml-base branch March 1, 2019 14:42
@galtm
Copy link
Member

galtm commented Mar 1, 2019

x:variable has @href. After merging this, please consider integrating x:variable into xml-base.xspec in #475

Sure. I was thinking of adding one scenario for /x:description/x:variable and one for //x:scenario/x:variable. Is it worthwhile for me to check the case where the variable definition uses @select in addition to @href, in addition to the case of @href by itself?

@AirQuick
Copy link
Member Author

AirQuick commented Mar 1, 2019

Thanks, @galtm.

Is it worthwhile for me to check the case where the variable definition uses @select in addition to @href, in addition to the case of @href by itself?

I'm not quite sure... So please add any test cases as you find useful and let's see what happens.

@cirulls
Merged this set of test cases.

@galtm
Copy link
Member

galtm commented Mar 1, 2019

please add any test cases as you find useful and let's see what happens.

@AirQuick
OK. I just uploaded 1e13462.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants