Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up namespaces in Compilation.md #521

Merged
merged 6 commits into from
Feb 20, 2019
Merged

Fix up namespaces in Compilation.md #521

merged 6 commits into from
Feb 20, 2019

Conversation

AirQuick
Copy link
Member

@AirQuick AirQuick commented Feb 18, 2019 •
edited
Loading

This pull request fixes up namespaces in Compilation.md (and attempts to simplify #475 in part).

  • 680e12b replaces t: with x:, because t: seems to be an old minor convention and mixing x: and t: just complicates the overall description. What do you think, @galtm ?
  • 31dd8a4 prefixes XSpec element names with x:.
  • The other commits fix namespaces to reflect the actual behavior.

@AirQuick AirQuick added this to the v1.3.0 milestone Feb 18, 2019
@AirQuick AirQuick requested a review from galtm February 18, 2019 07:18
@galtm
Copy link
Member

galtm commented Feb 20, 2019

  • mixing x: and t: just complicates the overall description. What do you think, @galtm ?

I agree. This change looks good. I did some spot-checking against actual behavior.

After you merge this PR, I'll update my PR #475.

galtm
galtm approved these changes Feb 20, 2019
View reviewed changes
Copy link
Member

@galtm galtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good clarifications and corrections.

@AirQuick AirQuick merged commit 58bc56f into xspec:master Feb 20, 2019
@AirQuick AirQuick deleted the fix_compilation-doc-ns branch February 20, 2019 15:23
@AirQuick
Copy link
Member Author

Thanks, @galtm.

@cirulls
Merged this documentation update.

@galtm galtm mentioned this pull request Feb 20, 2019
Merged
@galtm
Copy link
Member

galtm commented Feb 20, 2019

After you merge this PR, I'll update my PR #475.

Done (FYI to @AirQuick).

@cirulls cirulls mentioned this pull request Sep 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galtm galtm galtm approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AirQuick @galtm