Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify test:report-sequence() test param #525

Merged
merged 1,188 commits into from
Jul 4, 2019

Conversation

AirQuick
Copy link
Member

This pull request derives from #523. So needs to be handled after that.


test:report-sequence() receives a string and then creates an attribute. This pull request simplifies it. (receiving an attribute and outputting it as is)

This reverts commit 33a7adf.
This reverts commit f2586f1.
This reverts commit fb6f3b1.
…test_xquery

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	src/compiler/generate-common-tests.xsl
#	src/compiler/generate-query-utils.xql
#	src/compiler/generate-tests-utils.xsl
#	src/compiler/generate-xspec-tests.xsl
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-three-dots-result.html
#	test/end-to-end/cases/expected/xspec-rule-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/end-to-end/cases/xspec-three-dots.xspec
#	test/generate-tests-utils.xspec
#	test/generate-x-utils.xspec
#	test/generate-xspec-tests.xspec
#	test/unit-expect-xsl.xspec
#	test/win-bats/collection.xml
#	test/xspec-308.xspec
#	test/xspec-59_use-case-1.xspec
#	test/xspec-59_use-case-2.xspec
#	test/xspec-node-selection.xspec
#	test/xspec-variable.xspec
#	test/xspec.bats
…-dots_xquery

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	src/compiler/generate-common-tests.xsl
#	src/compiler/generate-query-utils.xql
#	src/compiler/generate-tests-utils.xsl
#	src/compiler/generate-xspec-tests.xsl
#	test/end-to-end/cases/expected/query/xspec-three-dots-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.html
#	test/end-to-end/cases/expected/xspec-rule-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/end-to-end/cases/xspec-three-dots.xspec
#	test/generate-tests-utils.xspec
#	test/generate-x-utils.xspec
#	test/generate-xspec-tests.xspec
#	test/unit-expect-xsl.xspec
#	test/win-bats/collection.xml
#	test/xspec-308.xspec
#	test/xspec-59_use-case-1.xspec
#	test/xspec-59_use-case-2.xspec
#	test/xspec-node-selection.xspec
#	test/xspec-variable.xspec
#	test/xspec.bats
…450-451

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	src/compiler/generate-common-tests.xsl
#	src/compiler/generate-query-utils.xql
#	src/compiler/generate-tests-utils.xsl
#	src/compiler/generate-xspec-tests.xsl
#	test/end-to-end/cases/expected/query/xspec-three-dots-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.html
#	test/end-to-end/cases/expected/xspec-rule-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/end-to-end/cases/xspec-three-dots.xspec
#	test/generate-tests-utils.xspec
#	test/generate-x-utils.xspec
#	test/generate-xspec-tests.xspec
#	test/unit-expect-xsl.xspec
#	test/win-bats/collection.xml
#	test/xspec-308.xspec
#	test/xspec-59_use-case-1.xspec
#	test/xspec-59_use-case-2.xspec
#	test/xspec-node-selection.xspec
#	test/xspec-variable.xspec
#	test/xspec.bats
# Conflicts:
#	.travis.yml
#	appveyor.yml
#	src/compiler/generate-common-tests.xsl
#	src/compiler/generate-query-utils.xql
#	src/compiler/generate-tests-utils.xsl
#	src/compiler/generate-xspec-tests.xsl
#	test/end-to-end/cases/expected/query/xspec-three-dots-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.html
#	test/end-to-end/cases/expected/xspec-rule-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/end-to-end/cases/xspec-three-dots.xspec
#	test/generate-tests-utils.xspec
#	test/generate-x-utils.xspec
#	test/generate-xspec-tests.xspec
#	test/unit-expect-xsl.xspec
#	test/win-bats/collection.xml
#	test/xspec-308.xspec
#	test/xspec-59_use-case-1.xspec
#	test/xspec-59_use-case-2.xspec
#	test/xspec-node-selection.xspec
#	test/xspec-variable.xspec
#	test/xspec.bats
# Conflicts:
#	.travis.yml
#	appveyor.yml
#	src/compiler/generate-common-tests.xsl
#	src/compiler/generate-query-utils.xql
#	src/compiler/generate-tests-utils.xsl
#	src/compiler/generate-xspec-tests.xsl
#	test/end-to-end/cases/expected/query/xspec-three-dots-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.html
#	test/end-to-end/cases/expected/xspec-rule-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/end-to-end/cases/xspec-three-dots.xspec
#	test/generate-tests-utils.xspec
#	test/generate-x-utils.xspec
#	test/generate-xspec-tests.xspec
#	test/unit-expect-xsl.xspec
#	test/win-bats/collection.xml
#	test/xspec-308.xspec
#	test/xspec-59_use-case-1.xspec
#	test/xspec-59_use-case-2.xspec
#	test/xspec-node-selection.xspec
#	test/xspec-variable.xspec
#	test/xspec.bats
# Conflicts:
#	.travis.yml
#	appveyor.yml
#	src/compiler/generate-common-tests.xsl
#	src/compiler/generate-query-utils.xql
#	src/compiler/generate-tests-utils.xsl
#	src/compiler/generate-xspec-tests.xsl
#	test/end-to-end/cases/expected/query/xspec-three-dots-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.html
#	test/end-to-end/cases/expected/xspec-rule-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/end-to-end/cases/xspec-three-dots.xspec
#	test/generate-tests-utils.xspec
#	test/generate-x-utils.xspec
#	test/generate-xspec-tests.xspec
#	test/unit-expect-xsl.xspec
#	test/win-bats/collection.xml
#	test/xspec-308.xspec
#	test/xspec-59_use-case-1.xspec
#	test/xspec-59_use-case-2.xspec
#	test/xspec-node-selection.xspec
#	test/xspec-variable.xspec
#	test/xspec.bats
# Conflicts:
#	.travis.yml
#	appveyor.yml
#	src/compiler/generate-common-tests.xsl
#	src/compiler/generate-query-utils.xql
#	src/compiler/generate-tests-utils.xsl
#	src/compiler/generate-xspec-tests.xsl
#	test/end-to-end/cases/expected/query/xspec-three-dots-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.html
#	test/end-to-end/cases/expected/xspec-rule-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/end-to-end/cases/xspec-three-dots.xspec
#	test/generate-tests-utils.xspec
#	test/generate-x-utils.xspec
#	test/generate-xspec-tests.xspec
#	test/unit-expect-xsl.xspec
#	test/win-bats/collection.xml
#	test/xspec-308.xspec
#	test/xspec-59_use-case-1.xspec
#	test/xspec-59_use-case-2.xspec
#	test/xspec-node-selection.xspec
#	test/xspec-variable.xspec
#	test/xspec.bats
…s_generate-xspec-tests

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	src/compiler/generate-common-tests.xsl
#	src/compiler/generate-query-utils.xql
#	src/compiler/generate-tests-utils.xsl
#	src/compiler/generate-xspec-tests.xsl
#	test/end-to-end/cases/expected/query/xspec-three-dots-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.html
#	test/end-to-end/cases/expected/xspec-rule-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/end-to-end/cases/xspec-three-dots.xspec
#	test/generate-tests-utils.xspec
#	test/generate-x-utils.xspec
#	test/generate-xspec-tests.xspec
#	test/unit-expect-xsl.xspec
#	test/win-bats/collection.xml
#	test/xspec-308.xspec
#	test/xspec-59_use-case-1.xspec
#	test/xspec-59_use-case-2.xspec
#	test/xspec-node-selection.xspec
#	test/xspec-variable.xspec
#	test/xspec.bats
# Conflicts:
#	.travis.yml
#	appveyor.yml
#	src/compiler/generate-common-tests.xsl
#	src/compiler/generate-query-utils.xql
#	src/compiler/generate-tests-utils.xsl
#	src/compiler/generate-xspec-tests.xsl
#	test/end-to-end/cases/expected/query/xspec-three-dots-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.html
#	test/end-to-end/cases/expected/xspec-rule-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/end-to-end/cases/xspec-three-dots.xspec
#	test/generate-tests-utils.xspec
#	test/generate-x-utils.xspec
#	test/generate-xspec-tests.xspec
#	test/unit-expect-xsl.xspec
#	test/win-bats/collection.xml
#	test/xspec-308.xspec
#	test/xspec-59_use-case-1.xspec
#	test/xspec-59_use-case-2.xspec
#	test/xspec-node-selection.xspec
#	test/xspec-variable.xspec
#	test/xspec.bats
# Conflicts:
#	.travis.yml
#	appveyor.yml
#	src/compiler/generate-common-tests.xsl
#	src/compiler/generate-query-utils.xql
#	src/compiler/generate-tests-utils.xsl
#	src/compiler/generate-xspec-tests.xsl
#	test/end-to-end/cases/expected/query/xspec-three-dots-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.html
#	test/end-to-end/cases/expected/xspec-rule-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/end-to-end/cases/xspec-three-dots.xspec
#	test/generate-tests-utils.xspec
#	test/generate-x-utils.xspec
#	test/generate-xspec-tests.xspec
#	test/unit-expect-xsl.xspec
#	test/win-bats/collection.xml
#	test/xspec-308.xspec
#	test/xspec-59_use-case-1.xspec
#	test/xspec-59_use-case-2.xspec
#	test/xspec-node-selection.xspec
#	test/xspec-variable.xspec
#	test/xspec.bats
# Conflicts:
#	.travis.yml
#	appveyor.yml
#	src/compiler/generate-common-tests.xsl
#	src/compiler/generate-query-utils.xql
#	src/compiler/generate-tests-utils.xsl
#	src/compiler/generate-xspec-tests.xsl
#	test/end-to-end/cases/expected/query/xspec-three-dots-result.html
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/end-to-end/cases/xspec-three-dots.xspec
#	test/generate-tests-utils.xspec
#	test/generate-x-utils.xspec
#	test/generate-xspec-tests.xspec
#	test/unit-expect-xsl.xspec
#	test/win-bats/collection.xml
#	test/xspec-308.xspec
#	test/xspec-59_use-case-1.xspec
#	test/xspec-59_use-case-2.xspec
#	test/xspec-variable.xspec
#	test/xspec.bats
# Conflicts:
#	.travis.yml
#	appveyor.yml
#	src/compiler/generate-common-tests.xsl
#	src/compiler/generate-query-utils.xql
#	src/compiler/generate-tests-utils.xsl
#	src/compiler/generate-xspec-tests.xsl
#	test/end-to-end/cases/expected/query/xspec-three-dots-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.html
#	test/end-to-end/cases/expected/xspec-rule-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/end-to-end/cases/xspec-focus-1.xspec
#	test/end-to-end/cases/xspec-function.xspec
#	test/end-to-end/cases/xspec-import.xspec
#	test/end-to-end/cases/xspec-pending.xspec
#	test/end-to-end/cases/xspec-three-dots.xspec
#	test/generate-tests-utils.xspec
#	test/generate-x-utils.xspec
#	test/generate-xspec-tests.xspec
#	test/unit-expect-xsl.xspec
#	test/win-bats/collection.xml
#	test/xspec-308.xspec
#	test/xspec-59_use-case-1.xspec
#	test/xspec-59_use-case-2.xspec
#	test/xspec-node-selection.xspec
#	test/xspec-variable.xspec
#	test/xspec.bats
…-rnc

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	src/compiler/generate-common-tests.xsl
#	src/compiler/generate-query-utils.xql
#	src/compiler/generate-tests-utils.xsl
#	src/compiler/generate-xspec-tests.xsl
#	src/schemas/xspec.rnc
#	test/end-to-end/cases/expected/query/xspec-three-dots-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.html
#	test/end-to-end/cases/expected/xspec-rule-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/end-to-end/cases/xspec-focus-1.xspec
#	test/end-to-end/cases/xspec-function.xspec
#	test/end-to-end/cases/xspec-import.xspec
#	test/end-to-end/cases/xspec-pending.xspec
#	test/end-to-end/cases/xspec-three-dots.xspec
#	test/generate-tests-utils.xspec
#	test/generate-x-utils.xspec
#	test/generate-xspec-tests.xspec
#	test/unit-expect-xsl.xspec
#	test/win-bats/collection.xml
#	test/xspec-308.xspec
#	test/xspec-59_use-case-1.xspec
#	test/xspec-59_use-case-2.xspec
#	test/xspec-node-selection.xspec
#	test/xspec-variable.xspec
#	test/xspec.bats
…2018-12-04

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	src/compiler/generate-common-tests.xsl
#	src/compiler/generate-query-utils.xql
#	src/compiler/generate-tests-utils.xsl
#	src/compiler/generate-xspec-tests.xsl
#	src/schemas/xspec.rnc
#	test/end-to-end/cases/expected/query/xspec-three-dots-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.html
#	test/end-to-end/cases/expected/xspec-rule-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/end-to-end/cases/xspec-focus-1.xspec
#	test/end-to-end/cases/xspec-function.xspec
#	test/end-to-end/cases/xspec-import.xspec
#	test/end-to-end/cases/xspec-pending.xspec
#	test/end-to-end/cases/xspec-three-dots.xspec
#	test/generate-tests-utils.xspec
#	test/generate-x-utils.xspec
#	test/generate-xspec-tests.xspec
#	test/unit-expect-xsl.xspec
#	test/win-bats/collection.xml
#	test/xspec-308.xspec
#	test/xspec-59_use-case-1.xspec
#	test/xspec-59_use-case-2.xspec
#	test/xspec-node-selection.xspec
#	test/xspec-variable.xspec
#	test/xspec.bats
…2018-12-24

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	src/compiler/generate-common-tests.xsl
#	src/compiler/generate-query-utils.xql
#	src/compiler/generate-tests-utils.xsl
#	src/compiler/generate-xspec-tests.xsl
#	src/schemas/xspec.rnc
#	test/end-to-end/cases/expected/query/xspec-three-dots-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.html
#	test/end-to-end/cases/expected/xspec-rule-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/end-to-end/cases/xspec-focus-1.xspec
#	test/end-to-end/cases/xspec-function.xspec
#	test/end-to-end/cases/xspec-import.xspec
#	test/end-to-end/cases/xspec-pending.xspec
#	test/end-to-end/cases/xspec-three-dots.xspec
#	test/generate-tests-utils.xspec
#	test/generate-x-utils.xspec
#	test/generate-xspec-tests.xspec
#	test/unit-expect-xsl.xspec
#	test/win-bats/collection.xml
#	test/xspec-308.xspec
#	test/xspec-59_use-case-1.xspec
#	test/xspec-59_use-case-2.xspec
#	test/xspec-node-selection.xspec
#	test/xspec-variable.xspec
#	test/xspec.bats
…y-desc-ns

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	src/compiler/generate-common-tests.xsl
#	src/compiler/generate-query-utils.xql
#	src/compiler/generate-tests-utils.xsl
#	src/compiler/generate-xspec-tests.xsl
#	src/schemas/xspec.rnc
#	test/end-to-end/cases/expected/query/xspec-three-dots-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.html
#	test/end-to-end/cases/expected/xspec-rule-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/end-to-end/cases/xspec-focus-1.xspec
#	test/end-to-end/cases/xspec-function.xspec
#	test/end-to-end/cases/xspec-import.xspec
#	test/end-to-end/cases/xspec-pending.xspec
#	test/end-to-end/cases/xspec-three-dots.xspec
#	test/generate-tests-utils.xspec
#	test/generate-x-utils.xspec
#	test/generate-xspec-tests.xspec
#	test/unit-expect-xsl.xspec
#	test/win-bats/collection.xml
#	test/xspec-308.xspec
#	test/xspec-59_use-case-1.xspec
#	test/xspec-59_use-case-2.xspec
#	test/xspec-node-selection.xspec
#	test/xspec-variable.xspec
#	test/xspec.bats
# Conflicts:
#	.travis.yml
#	appveyor.yml
#	src/compiler/generate-common-tests.xsl
#	src/compiler/generate-query-utils.xql
#	src/compiler/generate-tests-utils.xsl
#	src/compiler/generate-xspec-tests.xsl
#	src/schemas/xspec.rnc
#	test/end-to-end/cases/expected/query/xspec-three-dots-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.html
#	test/end-to-end/cases/expected/xspec-rule-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/end-to-end/cases/xspec-focus-1.xspec
#	test/end-to-end/cases/xspec-function.xspec
#	test/end-to-end/cases/xspec-import.xspec
#	test/end-to-end/cases/xspec-pending.xspec
#	test/end-to-end/cases/xspec-three-dots.xspec
#	test/generate-tests-utils.xspec
#	test/generate-x-utils.xspec
#	test/generate-xspec-tests.xspec
#	test/unit-expect-xsl.xspec
#	test/win-bats/collection.xml
#	test/xspec-308.xspec
#	test/xspec-59_use-case-1.xspec
#	test/xspec-59_use-case-2.xspec
#	test/xspec-node-selection.xspec
#	test/xspec-variable.xspec
#	test/xspec.bats
…est_xquery

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	src/compiler/generate-common-tests.xsl
#	src/compiler/generate-query-utils.xql
#	src/compiler/generate-tests-utils.xsl
#	src/compiler/generate-xspec-tests.xsl
#	src/schemas/xspec.rnc
#	test/end-to-end/cases/expected/query/xspec-three-dots-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.html
#	test/end-to-end/cases/expected/xspec-rule-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/end-to-end/cases/xspec-focus-1.xspec
#	test/end-to-end/cases/xspec-function.xspec
#	test/end-to-end/cases/xspec-import.xspec
#	test/end-to-end/cases/xspec-pending.xspec
#	test/end-to-end/cases/xspec-three-dots.xspec
#	test/generate-tests-utils.xspec
#	test/generate-x-utils.xspec
#	test/generate-xspec-tests.xspec
#	test/unit-expect-xsl.xspec
#	test/win-bats/collection.xml
#	test/xspec-308.xspec
#	test/xspec-59_use-case-1.xspec
#	test/xspec-59_use-case-2.xspec
#	test/xspec-node-selection.xspec
#	test/xspec-variable.xspec
#	test/xspec.bats
…177_xquery

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	src/compiler/generate-common-tests.xsl
#	src/compiler/generate-query-utils.xql
#	src/compiler/generate-tests-utils.xsl
#	src/compiler/generate-xspec-tests.xsl
#	src/schemas/xspec.rnc
#	test/end-to-end/cases/expected/query/xspec-three-dots-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.html
#	test/end-to-end/cases/expected/xspec-rule-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/end-to-end/cases/xspec-focus-1.xspec
#	test/end-to-end/cases/xspec-function.xspec
#	test/end-to-end/cases/xspec-import.xspec
#	test/end-to-end/cases/xspec-pending.xspec
#	test/end-to-end/cases/xspec-three-dots.xspec
#	test/generate-tests-utils.xspec
#	test/generate-x-utils.xspec
#	test/generate-xspec-tests.xspec
#	test/unit-expect-xsl.xspec
#	test/win-bats/collection.xml
#	test/xspec-308.xspec
#	test/xspec-59_use-case-1.xspec
#	test/xspec-59_use-case-2.xspec
#	test/xspec-node-selection.xspec
#	test/xspec-variable.xspec
#	test/xspec.bats
…-153_xquery

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	src/compiler/generate-common-tests.xsl
#	src/compiler/generate-query-utils.xql
#	src/compiler/generate-tests-utils.xsl
#	src/compiler/generate-xspec-tests.xsl
#	src/schemas/xspec.rnc
#	test/end-to-end/cases/expected/query/xspec-three-dots-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.html
#	test/end-to-end/cases/expected/xspec-rule-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/end-to-end/cases/xspec-153.xspec
#	test/end-to-end/cases/xspec-focus-1.xspec
#	test/end-to-end/cases/xspec-function.xspec
#	test/end-to-end/cases/xspec-import.xspec
#	test/end-to-end/cases/xspec-pending.xspec
#	test/end-to-end/cases/xspec-three-dots.xspec
#	test/generate-tests-utils.xspec
#	test/generate-x-utils.xspec
#	test/generate-xspec-tests.xspec
#	test/unit-expect-xsl.xspec
#	test/win-bats/collection.xml
#	test/xspec-308.xspec
#	test/xspec-59_use-case-1.xspec
#	test/xspec-59_use-case-2.xspec
#	test/xspec-node-selection.xspec
#	test/xspec-variable.xspec
#	test/xspec.bats
@AirQuick AirQuick added this to the v1.4.0 milestone Apr 30, 2019
@AirQuick AirQuick merged commit e61f584 into xspec:master Jul 4, 2019
@AirQuick AirQuick deleted the simplify-report-test branch July 4, 2019 03:41
@AirQuick
Copy link
Member Author

AirQuick commented Jul 4, 2019

@cirulls
Merged this internal simplification.

@galtm galtm self-requested a review July 8, 2019 12:11
Copy link
Member

@galtm galtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I didn't see any other calls to the test:report-sequence function/template that need to change.

@galtm
Copy link
Member

galtm commented Jul 8, 2019

I guess my review was a bit late. I looked at this during the 4-day weekend but didn't have a chance to comment on the web site until today.

@cirulls
Copy link
Member

cirulls commented Jul 8, 2019

@galtm: thanks for reviewing it, it is always useful to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants