Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the pending scenario labels in xspec-focus-2.xspec #560

Merged
merged 1,312 commits into from
Jul 28, 2019

Conversation

AirQuick
Copy link
Member

@AirQuick AirQuick commented Apr 29, 2019

This pull request derives from #559. So needs to be handled after that.


test/xspec-focus-2.xspec verifies that @focus, x:pending and @pending take effect. But their labels (foo of <x:scenario focus="foo", <x:pending label="foo"> or <x:scenario pending="foo">) are not tested.

The labels are used in the XML/HTML/JUnit report files, hence they must be tested.

This pull request moves test/xspec-focus-2.xspec to test/end-to-end/cases/ so that its report files are tested.

# Conflicts:
#	test/end-to-end/cases/expected/query/xspec-67-result.html
#	test/end-to-end/cases/expected/query/xspec-three-dots-result.html
#	test/end-to-end/cases/xspec-67.xspec
#	test/end-to-end/cases/xspec-three-dots.xspec
#	test/generate-tests-utils.xspec
#	test/generate-x-utils.xspec
# Conflicts:
#	test/generate-tests-utils.xspec
# Conflicts:
#	test/win-bats/collection.xml
#	test/xspec.bats
# Conflicts:
#	test/end-to-end/cases/expected/query/xspec-three-dots-result.html
…01-22

# Conflicts:
#	.travis.yml
#	appveyor.yml
This reverts commit e67a373.
…t-css-uri

# Conflicts:
#	bin/xspec.bat
#	bin/xspec.sh
#	src/common/xspec-utils.xsl
#	src/compiler/generate-common-tests.xsl
#	src/compiler/generate-query-tests.xsl
#	src/compiler/generate-xspec-tests.xsl
#	src/schematron/schut-to-xspec.xsl
#	test/ant/build.xml
#	test/ant/worker/build-worker_util.xml
#	test/ant/worker/generate.xsl
#	test/end-to-end/cases/expected/schematron/schematron-01-result.html
#	test/end-to-end/cases/expected/stylesheet/coverage-tutorial-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-153-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-50-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-55-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-67-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-ambiguous-expect-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-focus-1-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-function-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-import-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-imported-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-pending-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-three-dots-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-xslt2-result.html
#	test/end-to-end/processor/base/_normalizer.xsl
#	test/end-to-end/processor/base/compare.xsl
#	test/end-to-end/processor/base/normalize.xsl
#	test/end-to-end/processor/html/_normalizer.xsl
#	test/xspec-utils.xspec
#	test/xspec.bats
This reverts commit cf6a80f.
…-file-ext

# Conflicts:
#	test/end-to-end/cases/expected/schematron-01-junit-norm.xml
#	test/end-to-end/cases/expected/xquery-tutorial-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-153-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-50-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-55-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-67-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-ambiguous-expect-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-focus-1-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-function-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-import-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-imported-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-pending-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-rule-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-xslt2-junit-norm.xml
…-position

# Conflicts:
#	src/compiler/generate-query-tests.xsl
#	src/compiler/generate-tests-utils.xsl
#	src/reporter/format-xspec-report.xsl
#	src/reporter/junit-report.xsl
#	test/ant/worker/build-worker_util.xml
#	test/ant/worker/generate.xsl
#	test/end-to-end/ant/base/worker/generate.xsl
#	test/end-to-end/cases/expected/query/xspec-153-junit.xml
#	test/end-to-end/cases/expected/query/xspec-67-junit.xml
#	test/end-to-end/cases/expected/query/xspec-ambiguous-expect-junit.xml
#	test/end-to-end/cases/expected/query/xspec-focus-1-result.html
#	test/end-to-end/cases/expected/query/xspec-focus-1-result.xml
#	test/end-to-end/cases/expected/query/xspec-function-result.html
#	test/end-to-end/cases/expected/query/xspec-function-result.xml
#	test/end-to-end/cases/expected/query/xspec-import-result.html
#	test/end-to-end/cases/expected/query/xspec-import-result.xml
#	test/end-to-end/cases/expected/query/xspec-imported-result.html
#	test/end-to-end/cases/expected/query/xspec-imported-result.xml
#	test/end-to-end/cases/expected/query/xspec-pending-result.html
#	test/end-to-end/cases/expected/query/xspec-pending-result.xml
#	test/end-to-end/cases/expected/query/xspec-three-dots-junit.xml
#	test/end-to-end/cases/expected/schematron/schematron-01-result.xml
#	test/end-to-end/cases/expected/stylesheet/coverage-tutorial-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-153-junit.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-153-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-50-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-55-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-67-junit.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-67-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-ambiguous-expect-junit.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-ambiguous-expect-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-focus-1-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-function-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-import-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-imported-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-pending-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-three-dots-junit.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-three-dots-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-xslt2-result.xml
#	test/end-to-end/cases/expected/xspec-153-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-67-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-ambiguous-expect-junit-norm.xml
#	test/end-to-end/cases/expected/xspec-three-dots-junit-norm.xml
#	test/end-to-end/processor/xml/_normalizer.xsl
…-position

# Conflicts:
#	src/compiler/generate-xspec-tests.xsl
#	test/end-to-end/cases/expected/schematron/schematron-01-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-153-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-50-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-55-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-67-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-ambiguous-expect-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-focus-1-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-function-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-import-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-imported-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-pending-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-three-dots-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-xslt2-result.xml
@AirQuick AirQuick merged commit 3a8096a into xspec:master Jul 28, 2019
@AirQuick AirQuick deleted the e2e-test-focus-2 branch July 28, 2019 17:02
@AirQuick
Copy link
Member Author

@cirulls
Merged this enhancement of tests.

Thanks @galtm for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants