Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noting CSS difference between actual and expected #582

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Conversation

galtm
Copy link
Member

@galtm galtm commented Jul 3, 2019

This wiki change is to answer a question I had the first time I reviewed some files in the test/end-to-end area.

@AirQuick AirQuick added this to the v1.4.0 milestone Jul 4, 2019
Copy link
Member

@AirQuick AirQuick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for augmenting the documentation. Looks good to me.

@AirQuick
Copy link
Member

AirQuick commented Jul 4, 2019

Wiki update also looks good to me. Thanks for sharing the tips.

If you earlier ran tests manually..., then remove the inner xspec folder

This behavior annoys me, too. We may want to have the test script handle the temp folder more gracefully.

@AirQuick AirQuick merged commit fc03e7a into master Jul 4, 2019
@AirQuick AirQuick added the test label Jul 4, 2019
@AirQuick
Copy link
Member

AirQuick commented Jul 4, 2019

@cirulls
Merged this test documentation update.

@galtm galtm deleted the galtm-patch-1 branch July 8, 2019 12:23
@galtm
Copy link
Member Author

galtm commented Jul 8, 2019

Wiki update also looks good to me. Thanks for sharing the tips.

No problem. Thanks for reviewing them. More graceful handling of the temp folder would be nice, subject to time/priority constraints.

@cirulls
Copy link
Member

cirulls commented Jul 8, 2019

This behavior annoys me, too. We may want to have the test script handle the temp folder more gracefully.

This occurred to me too. +1 for implementing a graceful handling of the temp folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants