Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary static-base-uri() #589

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

AirQuick
Copy link
Member

@AirQuick AirQuick commented Aug 1, 2019

This pull request just removes static-base-uri() calls which are not necessary.

There is no automated test for format-xspec-report-folding.xsl. So I manually tested this pull request and verified this:

  • ant -lib "saxon9ee.jar" -Dxspec.xml=tutorial\escape-for-regex.xspec -Dxspec.html.reporter.xsl=src\reporter\format-xspec-report-folding.xsl generates the same escape-for-regex-result.html as the current master (except for timestamp).

Copy link
Member

@galtm galtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward, and you've covered all the instances of this syntax that I found.

@AirQuick AirQuick added this to the v1.5.0 milestone Sep 8, 2019
@AirQuick AirQuick merged commit 494b029 into xspec:master Sep 9, 2019
@AirQuick AirQuick deleted the rm-fn-static-base-uri branch September 9, 2019 19:56
@AirQuick
Copy link
Member Author

AirQuick commented Sep 9, 2019

@cirulls
Merged this internal cleanup.
I guess you're going to full-or-semi-automate the release note and don't need to be pinged on each merge anymore?

Thanks @galtm for the review.

@cirulls
Copy link
Member

cirulls commented Sep 10, 2019

Yes, no need to ping me any more, thanks for doing it till now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants