Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid col element in result HTML #609

Merged
merged 6 commits into from
Sep 19, 2019

Conversation

AirQuick
Copy link
Member

@AirQuick AirQuick commented Sep 7, 2019

It's a little bit annoying that when you open the result HTML in Oxygen, the validation complains about these things:

  • element "col" not allowed here
  • attribute "width" not allowed here

This pull request just fixes them.

There is no automated test for format-xspec-report-folding.xsl. So I manually tested this pull request and verified this:

  • ant -lib "saxon9ee.jar" -Dxspec.xml=tutorial\escape-for-regex.xspec -Dxspec.html.reporter.xsl=src\reporter\format-xspec-report-folding.xsl generates the same escape-for-regex-result.html as the current master (except for the fix).

@AirQuick AirQuick added the bug label Sep 7, 2019
@AirQuick AirQuick added this to the v1.5.0 milestone Sep 8, 2019
@AirQuick AirQuick merged commit 4556cdd into xspec:master Sep 19, 2019
@AirQuick AirQuick deleted the result-html_colgroup branch September 19, 2019 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant