Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Ant import with include #671

Merged
merged 9 commits into from
Oct 9, 2019

Conversation

AirQuick
Copy link
Member

@AirQuick AirQuick commented Oct 4, 2019

As cited in #669, this pull request replaces Ant <import> with <include> wherever appropriate.
When <import> is still used, this pull request adds comments for clarifying the reason.

The change pertains only to the tests. No change in XSpec code.

How I tested it

The following deliberate failures demonstrate that the relevant tests are still working as expected:

@AirQuick AirQuick added the test label Oct 4, 2019
@AirQuick AirQuick added this to the v1.5.0 milestone Oct 4, 2019
@AirQuick AirQuick marked this pull request as ready for review October 4, 2019 18:04
@AirQuick
Copy link
Member Author

AirQuick commented Oct 9, 2019

Merging this because

  • the need for the test is based on a real use case
  • the relevant tests are still working as expected

@AirQuick AirQuick merged commit 9fe73d8 into xspec:master Oct 9, 2019
@AirQuick AirQuick deleted the replace-ant-import-w-include branch October 9, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant