Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ant-based test: Parameterize query for fn:collection() #703

Merged
merged 2 commits into from
Nov 3, 2019

Conversation

AirQuick
Copy link
Member

@AirQuick AirQuick commented Oct 31, 2019

Summary

test/ant/worker/generate.xsl uses fn:collection() to collect XSpec files. URI query parameter is hardcoded:

select="concat($XSPECFILES-DIR-URI, '?select=*.xspec')" />

This pull request parameterizes it.

Why

With this change, you can quickly experiment query parameters such as recursive option:

C:\xspec>test\run-xspec-tests-ant.cmd -Dxspecfiles.dir="C:\test" -Dxspecfiles.dir.url.query="select=*.xspec;recurse=yes"

Scope of this change

This change pertains only to CI tests. Nothing is changed in XSpec itself.

Test

I ran the following commands on the current master and on this pr branch

C:\xspec>test\run-xspec-tests-ant.cmd -Dthread.count=1 -logfile "test.log"
C:\xspec>test\end-to-end\run-e2e-tests.cmd -Dthread.count=1 -logfile "e2e.log"

and compared the logs to verify that there's no unignorable difference between the current master and this pr branch.

@AirQuick AirQuick added the test label Oct 31, 2019
@AirQuick AirQuick added this to the v1.5.0 milestone Oct 31, 2019
@AirQuick AirQuick merged commit ca9f3fd into xspec:master Nov 3, 2019
@AirQuick AirQuick deleted the ant-test-collection-query branch November 3, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant