Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for issue 700 (Catch error messages from xsl:message terminate=yes) #715

Merged
merged 2 commits into from
Nov 9, 2019

Conversation

AirQuick
Copy link
Member

@AirQuick AirQuick commented Nov 8, 2019

Closes #700

This pull request adds a test for #700.

  • The test is skipped until Saxon implements the required feature. Right now, the test assumes the implementation to happen on the next maintenance release of 9.9. If postponed, this pull request needs to be updated accordingly.
  • Right now, the 2nd x:expect expects a string. But x:result?err?value will be a node. The x:expect in question will need to be updated using TVT (feat: support Text Value Templates (expand-text) #711) or another way.

@AirQuick AirQuick added the test label Nov 8, 2019
@AirQuick AirQuick added this to the v1.5.0 milestone Nov 8, 2019
@AirQuick AirQuick merged commit e93bca9 into xspec:master Nov 9, 2019
@AirQuick AirQuick deleted the test_issue-700 branch November 9, 2019 15:25
@galtm
Copy link
Member

galtm commented May 1, 2023

In #749, the test started checking for the processing instruction mentioned in https://saxonica.plan.io/issues/4376#note-2 :

Note that Saxon inserts a processing instruction into the xsl:message document containing the error code and the location of the xsl:message instruction. This is convenient, but not strictly according to spec.

Saxon 11 does not insert that PI. The change appears to be intentional; notice the differences in the Details section between these pages of the Saxon documentation for versions 10 and 11:

https://saxonica.com/documentation10/index.html#!xsl-elements/message
https://saxonica.com/documentation11/index.html#!xsl-elements/message

I'm working on adding Saxon 11 testing to XSpec. Because this message treatment has changed in Saxon and because the XSLT spec does not require the PI anyway, I'm inclined to loosen the expectation in this test to stop looking for a PI. If you prefer a different resolution, please comment, either here or in an upcoming pull request that I create about Saxon 11 compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catch error messages from <xsl:message terminate="yes"/>
2 participants