Remove redundant -ext:on from build.xml #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build.xmlsetsALLOW_EXTERNAL_FUNCTIONSon, but its default is on per Saxon doc. I looked back the corresponding commit message but there was no reason provided.This pull request removes the redundant lines from
build.xml. If we reinstate the lines, we will need to provide source code comments and/or tests to show why those redundant lines are necessary.Non-commercial Saxon versions are tested on CI. As for the commercial Saxon, I tested with Saxon-EE 9.9.1.5 (Windows), 9.8.0.12 (Linux) and 9.7.0.21 (Windows) on my local machine.