-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish XSpec development version as Oxygen add-on #743
Conversation
Will the add-on be for interim development versions only or for a mix of both development versions and official releases? Covering both sounds good to me, because if Oxygen makes the add-on process really easy, it would be a shame for that process to be unavailable to people who want the latest official release. Is it a problem if 1.5.0 ends up out of sequence between some versions 0.0.x and 0.0.(x+1)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are a few comments from looking at the code, but I have yet to try the workflow first-hand. I plan to do that on Monday.
I'm thinking to treat an official release as just one of the latest snapshots of the development version. A possible release flow would be like this:
What do you think? |
@AirQuick , your plan sounds good to me. Thanks for the clarifying answers to my questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the workflow you outlined (on Windows with v21.0, build 2019022207) and everything worked smoothly. I don't have any comments beyond what I posted the other day.
The wiki looks great! I changed only one sentence to clarify the notification/update process. |
Submitted as #751 |
@AirQuick: The procedure in #743 (comment) looks good to me. Thanks for updating this Wiki page. |
This pull request publishes a snapshot of the development version of XSpec as an Oxygen add-on.
I would like to propose publishing a new development version via this add-on channel whenever a notable change gets merged into
master
.The initial add-on version is v0.0.2 which installs the snapshot of XSpec b19ccd7.
The add-on v0.0.1 exists too, but it's just for upgrade testing.
What is Oxygen add-on?
See an Oxygen page. Their video demonstrates end-user experience.
What is the development version of XSpec?
Just a specific commit version of
master
branch.Where is the add-on package?
No package built. We can take advantage of this repository's queer structure. (Cloning is deploying.)
This pull request just adds an add-on descriptor file (
oxygen-addon.xml
). The add-on descriptor locates one of the GitHub tree zips.Once we merge this pull request, the add-on descriptor URL will be
https://github.com/xspec/xspec/raw/master/oxygen-addon.xml
. We could possibly ask SyncRO Soft to XInclude our URL from their community descriptor.Why version 0.0.z?
See a comment in
oxygen-addon.xml
.How I tested it
I tested this add-on on Oxygen
on Windows and Linux using the following steps.
You can also follow this steps to see what will happen when we publish this add-on. If your Oxygen version is older than 19, please let me know and I'll look into what we can do.
Preparing the test
Make sure you don't have another XSpec installed.
Open
test/xspec-variable.xspec
on Oxygen.x:variable
.Installing v0.0.1 of the add-on
Oxygen menu - Help - Install new add-ons.
Specify
https://github.com/AirQuick/xspec/raw/oxy-addon/oxygen-addon.xml
in Show add-ons from box.Do not install v0.0.2 at this time.
Uncheck Show only the latest versions of the add-ons.
Check v0.0.1 (not v0.0.2) and click Next.
Check I accept... and click Install.
"To apply these changes, you must restart..." notification pops up. Click OK.
Close Oxygen entirely.
Launch Oxygen again. It may take some time.
"1 new update(s) are available..." notification pops up. Click Close for now.
Verify that the installed add-on v0.0.1 takes effect.
test/xspec-variable.xspec
on Oxygen.x:variable
.Upgrading from v0.0.1 to v0.0.2
Oxygen menu - Help - Check for add-ons updates.
Make sure you have XSpec checked. Click Update.
Check I accept... and click Finish.
"To apply these changes, you must restart..." notification pops up. Click OK.
Close Oxygen entirely.
Launch Oxygen again. It may take some time.
Verify that the upgraded add-on v0.0.2 takes effect.
test/xspec-variable.xspec
on Oxygen.xspec-variable.xspec
. It should succeed and the report HTML should be opened.Uninstalling the add-on
Oxygen menu - Help - Manage add-ons.
Check XSpec v0.0.2 and click the bottom left Uninstall button.
"Are you sure..." pops up. Click Yes.
"To apply these changes, you must restart..." notification pops up. Click OK.
Close Oxygen entirely.
Launch Oxygen again. It may take some time.
Oxygen menu - Options - Preferences - Add-ons.
Delete
https://github.com/AirQuick/xspec/raw/oxy-addon/oxygen-addon.xml
to clear the residue of this testing.