forked from expath/xspec
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(report): report x:scenario and x:expect ID in XML report #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They now contain x:scenario and x:expect ID
Code Refactoring
Features
Tests
Contributors |
AirQuick
force-pushed
the
scenario-expect-id
branch
from
February 5, 2020 10:28
12554b1
to
b349ddc
Compare
Testing x:* in user-content is not viable
AirQuick
force-pushed
the
scenario-expect-id
branch
from
February 5, 2020 10:31
b349ddc
to
41508fc
Compare
…xpect-id # Conflicts: # test/end-to-end/cases/expected/stylesheet/xspec-55-result.xml
Merging this, as this doesn't change end-user facing behavior. |
@xspec/oxygen-xml-editor-xspec-support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XSpec compilers and reporters rely on
generate-id()
for ID generation. Consequently,oXygen plugin uses a patched version of XSpec to generate a report XML like this:
To ease those pain points, this pull request
x:scenario
andx:expect
@template-id
above, but under a different attribute name (@id
) to better represent its characteristicstest/end-to-end/
no longer have to normalize@id
.