refactor: test:generate-variable-declarations mode

[AirQuick]

In an attempt to make a fix of #777, I found these difficulties in mode="test:generate-variable-declarations":

• The responsibility of analyzing context is dispersed.
• The variable names being generated are sometimes hard-coded, sometimes dynamic.
• Its code path from the initiator to the outcome is a winding road. Several modes and some temporary nodes are involved.
• Its parameters are not named consistently.

I guess this complexity grew over time while integrating the independent test: module into XSpec and splitting XSLT and XQuery.

To mitigate it, this pull request refactors mode="test:generate-variable-declarations":

• Now mode="test:generate-variable-declarations" owns the responsibility of analyzing context.
• Now the variable names being generated are obtained from test:variable-name().
• The intermediate modes/nodes have been eliminated.
• All the parameters except for the tunnel $pending have been eliminated.

No actual change in the compiled stylesheets/queries.

Besides the automated tests, I manually compared the compiled stylesheets/queries with the current master using this command

for %I in ( test\xspec-node-selection.xspec test\xspec-variable.xspec ) do ( bin\xspec.bat "%~I" && bin\xspec.bat -q "%~I" && bin\xspec.bat "%~dpnI_stylesheet%~xI" )

and verified that only generate-id()-driven variable names were different.

[commit-lint]

Code Refactoring

• relocate language-specific parameters (27e6f69)
• wrap if-then-else (bb685b4)
• take attribute(name) by default (e616a80)
• remove xsl:for-each which is no longer necessary (4348948)
• xslt: default $type based on context element (de59dcc)
• rename $var to $name (53a73d7)
• xquery: rename $global to $is-global (b866e96)
• rename $var-doc to $temp-doc-name (ea4d486)
• rename $var-doc-uri to $temp-uri-name (16a87d0)
• xslt: rename $type to boolean $is-param (5397f40)
• rename $variable-is-pending to $is-pending (7122874)
• enable test:generate-variable-declarations to exclude child nodes (b7b6603)
• fall back on generate-id() by default (79913b1)
• use common function to get variable names (7a13fa4)
• xquery: determine $is-global in callee (19730b4)
• xslt: determine $is-param in callee (a5e8e66)
• wrap some long lines (39bbf98)
• remove x:generate-declarations which is no longer necessary (9aa6025)

Documentation

• add comments to some xsl:param and xsl:variable (789c709)
• xquery: adjust indent in comment (fa820a6)

Contributors

@AirQuick

[AirQuick]

There may be a better refactoring idea; even so, I believe it is better to start from this one than from the current code. So, merging this. I'll soon submit a fix for #777 and ask someone's review.