Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename x:compile-params to x:compile-global-params-and-vars #805

Merged
merged 4 commits into from
Mar 5, 2020

Conversation

AirQuick
Copy link
Member

@AirQuick AirQuick commented Mar 2, 2020

The template name x:compile-params suggests it handles all x:param. Actually it handles global x:param and global x:variable.
This pull request just changes the template name to better reflect its responsibility. Also the term test suite params is removed, as it is not used elsewhere.

@AirQuick AirQuick added this to the v1.6.0 milestone Mar 2, 2020
@commit-lint
Copy link

commit-lint bot commented Mar 2, 2020

Code Refactoring

  • rename x:compile-params to x:compile-global-params-and-vars (8ee504c)

Contributors

@AirQuick

@AirQuick AirQuick merged commit b8931e8 into xspec:master Mar 5, 2020
@AirQuick AirQuick deleted the rename-compile-params-mode branch March 5, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant