Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: resolve lexical QName using a util function #817

Merged
merged 3 commits into from
Mar 9, 2020

Conversation

AirQuick
Copy link
Member

@AirQuick AirQuick commented Mar 6, 2020

There are multiple places where a lexical QName needs to be resolved without using the default namespace. This pull request sets up a utility function for it.

@AirQuick AirQuick added this to the v1.6.0 milestone Mar 6, 2020
@commit-lint
Copy link

commit-lint bot commented Mar 6, 2020

Code Refactoring

  • resolve lexical QName using a util function (0d9b4aa)

Contributors

@AirQuick

# Conflicts:
#	src/compiler/generate-common-tests.xsl
@galtm galtm self-requested a review March 6, 2020 22:25
Copy link
Member

@galtm galtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Comment on lines +427 to +428
"Notes" in https://www.w3.org/TR/xpath-functions-31/#func-resolve-QName or more
specifically p.866 of XSLT 2.0 and XPath 2.0 Programmer's Reference, 4th Edition.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful references

@AirQuick AirQuick merged commit 3bc722d into xspec:master Mar 9, 2020
@AirQuick AirQuick deleted the resolve-qname-util branch March 9, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants