Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: verify only leaf dir's inexistence #886

Merged
merged 10 commits into from
Mar 31, 2020

Conversation

AirQuick
Copy link
Member

@AirQuick AirQuick commented Mar 30, 2020

Some Bats tests verifies that a directory does not exist, which is error prone.
This pull request enhances it so that the tests also verify that the parent dir does exist.

Also added are some minor improvements.

d42f4e5 is a temporary commit to verify the dir inexistence check.

@AirQuick AirQuick added the test label Mar 30, 2020
@AirQuick AirQuick added this to the v1.6.0 milestone Mar 30, 2020
@commit-lint
Copy link

commit-lint bot commented Mar 30, 2020

Tests

  • verify that only leaf dir not exist (c83d905)
  • pushd before calling each case (ecd81d9)
  • comment about a quote char in CMD /C option (1c9a256)
  • use parent dir absolute path variable (d40aace)
  • add comments to setup() and teardown() (ccfa9f0)
  • fail in leaf dir check deliberately (d42f4e5)
  • remove unnecessary SAXON_CP (66ec608)
  • not necessary to do pushd (abfedc8)

Contributors

@AirQuick

@AirQuick AirQuick marked this pull request as ready for review March 30, 2020 16:15
@AirQuick
Copy link
Member Author

The temporary commit failed as expected:

@AirQuick AirQuick changed the title test: verify that only leaf dir's inexistence test: verify only leaf dir's inexistence Mar 30, 2020
@AirQuick AirQuick merged commit 971894a into xspec:master Mar 31, 2020
@AirQuick AirQuick deleted the bats-check-leaf-dir-not-exist branch March 31, 2020 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant