trycatch font parsing in ligatures addon

[LabhanshAgrawal]

Adding the fix for #3547 to ligatures addon directly so that it can be used with older xterm.js versions
Ref #3617

[LabhanshAgrawal]

Tests failing on

xterm.js/addons/xterm-addon-ligatures/src/index.test.ts

Line 142 in 6c18b7f

it('fails if it finds but cannot load the font', async () => {

and

xterm.js/addons/xterm-addon-ligatures/src/index.test.ts

Line 182 in 6c18b7f

it('ensures no empty errors are thrown', async () => {

As these expect errors being thrown which this pr suppresses, any suggestions?

[Tyriar]

to ligatures addon directly so that it can be used with older xterm.js versions

@LabhanshAgrawal isn't the right fix here to use the correct ligatures addon for the xterm.js version and update xterm.js if it's not fixed before? Throwing here and using the existing catch does seem like the more correct thing to do (instead of having a catch in xterm that would never be hit).

[Tyriar]

Closing out since #3617 can now be fixed by updating to latest webgl beta

[LabhanshAgrawal]

@LabhanshAgrawal isn't the right fix here to use the correct ligatures addon for the xterm.js version and update xterm.js if it's not fixed before?

The issue was due to opentype not being able to parse some font on macOS 12, so none of the earlier ligatures addon versions would be able to work in that scenario even with previous xterm versions.

Throwing here and using the existing catch does seem like the more correct thing to do (instead of having a catch in xterm that would never be hit).

Didn't really get what you're referring to here.

Closing out since #3617 can now be fixed by updating to latest webgl beta

👍

[Tyriar]

Didn't really get what you're referring to here.

Would just prefer not to have try/catches everywhere when only one of them should be used in practice. We prefer to take a more evergreen approach as supporting older versions takes a bunch of effort.